From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless Date: Mon, 07 Jul 2014 21:54:35 -0400 Message-ID: References: <52D14E9F.5030001@gmx.at> <52D16627.4080604@gmx.at> <52D2661A.4000105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1404784514 27031 80.91.229.3 (8 Jul 2014 01:55:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Jul 2014 01:55:14 +0000 (UTC) Cc: 16038@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 08 03:55:08 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X4Kcd-0005wa-QF for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jul 2014 03:55:07 +0200 Original-Received: from localhost ([::1]:53543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Kcd-0005Ni-Bu for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Jul 2014 21:55:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Kca-0005N2-1H for bug-gnu-emacs@gnu.org; Mon, 07 Jul 2014 21:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4KcY-00039q-MC for bug-gnu-emacs@gnu.org; Mon, 07 Jul 2014 21:55:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4KcY-00039S-Ic for bug-gnu-emacs@gnu.org; Mon, 07 Jul 2014 21:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4KcY-00045C-39 for bug-gnu-emacs@gnu.org; Mon, 07 Jul 2014 21:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jul 2014 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16038 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16038-submit@debbugs.gnu.org id=B16038.140478448015646 (code B ref 16038); Tue, 08 Jul 2014 01:55:02 +0000 Original-Received: (at 16038) by debbugs.gnu.org; 8 Jul 2014 01:54:40 +0000 Original-Received: from localhost ([127.0.0.1]:46353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4KcB-00044H-SM for submit@debbugs.gnu.org; Mon, 07 Jul 2014 21:54:40 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:41395 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4Kc8-000445-OZ for 16038@debbugs.gnu.org; Mon, 07 Jul 2014 21:54:37 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4Kc7-0007Tx-SV; Mon, 07 Jul 2014 21:54:35 -0400 X-Spook: Bellcore SAPO Defcon satellite imagery North Korea Putin X-Ran: (Cr@m^qnlD&$q=)T92&T>;g{|r[E,;yEg@)b*V(Gr)2z0R'?N]T}>P(J2J!a\;+S91QLc5 X-Hue: white X-Attribution: GM In-Reply-To: (Leo Liu's message of "Tue, 14 Jan 2014 08:23:18 +0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91292 Archived-At: Leo Liu wrote: > Could we remove the following two add-hooks? > > > --8<---------------cut here---------------start------------->8--- > (add-hook 'temp-buffer-setup-hook 'help-mode-setup) > (add-hook 'temp-buffer-show-hook 'help-mode-finish) > --8<---------------cut here---------------end--------------->8--- If you want to do this (I know you already did...), you need to add an incompatible change entry to NEWS about this, and you need to audit every single use of with-output-to-temp-buffer to find the ones that expected their output buffers to be in help mode. Which I guess would be, umm, all of them? The first one I tried: emacs -Q -f report-emacs-bug *Bug Help* buffer is in Help mode in 24.3.92, and fundamental in trunk. Does it actually matter in that case? Maybe not, but the buffer was clearly intended te be in help mode. And here's a case where it definitely does matter http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17966 (This report has become rather long; I hope it doesn't get too much longer.)