From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r102179: Silence gnus-util.el compilation. Date: Mon, 01 Nov 2010 12:35:46 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1288632799 19811 80.91.229.12 (1 Nov 2010 17:33:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 1 Nov 2010 17:33:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 18:33:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PCyFu-0006GV-Bz for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 18:33:14 +0100 Original-Received: from localhost ([127.0.0.1]:38522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCy8h-00053y-Pd for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 13:25:47 -0400 Original-Received: from [140.186.70.92] (port=54513 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCxMK-0004ij-V4 for emacs-devel@gnu.org; Mon, 01 Nov 2010 12:35:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCxMJ-0003rF-VP for emacs-devel@gnu.org; Mon, 01 Nov 2010 12:35:48 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:58340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCxMJ-0003rB-Sm for emacs-devel@gnu.org; Mon, 01 Nov 2010 12:35:47 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PCxMI-0004dZ-QT; Mon, 01 Nov 2010 12:35:46 -0400 X-Spook: counter terrorism security SSL Vince Foster analyzer X-Ran: ]p^*qi4q#LEi5d4iWbu-!=K0ei7ADITImBxNF.x?yk]^4[;t2mf''|R`F^Z'EWfhd&rW@y X-Hue: cyan X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Mon\, 01 Nov 2010 09\:48\:22 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132242 Archived-At: Stefan Monnier wrote: >> -(autoload 'iswitchb-read-buffer "iswitchb") >> +(declare-function iswitchb-read-buffer "iswitchb" >> + (prompt &optional default require-match start matches-set)) >> +(defvar iswitchb-temp-buflist) >> + >> (defun gnus-iswitchb-completing-read (prompt collection &optional require-match >> initial-input history def) >> "`iswitchb' based completing-read function." >> + (require 'iswitchb) >> (let ((iswitchb-make-buflist-hook >> (lambda () >> (setq iswitchb-temp-buflist > > I'm not convinced that declare-function+require is better than autoload. > What was the problem with autoload? It might load iswitchb while an iswitchb variable was let bound. Eg: (let ((iswitchb-make-buflist-hook t)) (require 'iswitchb)) C-h v iswitchb-make-buflist-hook It is void as a variable. PS could you reply to emacs-devel rather than emacs-diffs in these cases? (I don't know why emacs-diffs is even configured to accept postings other than from Savannah.)