From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: peder@news.klingenberg.no (Peder O. Klingenberg) Newsgroups: gmane.emacs.devel Subject: Re: Small patch to emacsbug.el Date: Tue, 28 Oct 2014 20:56:06 +0100 Organization: Persons in a Position to Know, inc. Message-ID: References: <83h9yo2mr0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414526233 17215 80.91.229.3 (28 Oct 2014 19:57:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Oct 2014 19:57:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 28 20:57:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XjCt4-0007xa-T1 for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2014 20:57:03 +0100 Original-Received: from localhost ([::1]:41218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjCt4-0007Qk-J6 for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2014 15:57:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjCsj-0007QS-Jx for emacs-devel@gnu.org; Tue, 28 Oct 2014 15:56:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjCsc-0007pa-49 for emacs-devel@gnu.org; Tue, 28 Oct 2014 15:56:41 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:55118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjCsb-0007pS-U0 for emacs-devel@gnu.org; Tue, 28 Oct 2014 15:56:34 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XjCsL-0007Q6-VO for emacs-devel@gnu.org; Tue, 28 Oct 2014 20:56:17 +0100 Original-Received: from luna.netfonds.no ([80.91.225.79]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Oct 2014 20:56:17 +0100 Original-Received: from peder by luna.netfonds.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Oct 2014 20:56:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: luna.netfonds.no User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:DT8CKyfYM7dBKV76nmMG5Cj+LPE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175940 Archived-At: On Tue, Oct 28 2014 at 18:16, Eli Zaretskii wrote: > What if the user overrides that default, and uses a different mail > mode? Then I guess that user will have some unused functions loaded, as well as some variables defined that she has no use for? I was basically just cargo-culting the existing code. Existing code in emacsbug.el has ;; It's the default mail mode, so it seems OK to use its features. (autoload 'message-bogus-recipient-p "message") (defvar message-send-mail-function) I just added one more function and one more variable, and moved the whole bunch, including comment, earlier in the file, because I used those functions earlier in the file and thought it logical to place the definitions before the uses. Autoload of one function causes the entire file to be loaded, does it not? So my additions are more for documentation purposes than any actual functional change. ...Peder... -- I wish a new life awaited _me_ in some off-world colony.