From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Zorn Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add option to ERC to make all connections use SSL. Date: Sun, 03 Aug 2014 10:39:49 -0400 Message-ID: References: <87zjfqiokt.fsf@lifelogs.com> <87mwbnu6kf.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1407077435 1635 80.91.229.3 (3 Aug 2014 14:50:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Aug 2014 14:50:35 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 03 16:50:29 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XDx7E-0002Da-Jd for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2014 16:50:28 +0200 Original-Received: from localhost ([::1]:48205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDx7E-0004WZ-62 for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2014 10:50:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDx70-0004VZ-RZ for emacs-devel@gnu.org; Sun, 03 Aug 2014 10:50:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDx6t-0001st-D5 for emacs-devel@gnu.org; Sun, 03 Aug 2014 10:50:14 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:51677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDx6t-0001rQ-6v for emacs-devel@gnu.org; Sun, 03 Aug 2014 10:50:07 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XDx6r-0001nM-30 for emacs-devel@gnu.org; Sun, 03 Aug 2014 16:50:05 +0200 Original-Received: from 69-84-100-215-dhcp.mia.fl.atlanticbb.net ([69.84.100.215]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Aug 2014 16:50:05 +0200 Original-Received: from jzornn by 69-84-100-215-dhcp.mia.fl.atlanticbb.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Aug 2014 16:50:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-84-100-215-dhcp.mia.fl.atlanticbb.net Cancel-Lock: sha1:mKK58Fv2zruM1dMqHDC8PaES8ek= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173403 Archived-At: On Sat, 2 Aug 2014 23:17:13 +0530, Vibhav Pant wrote: > Agreed. I have redone the patch and added some more features: > 1. erc-ssl-servers: Alist of servers (ADDRESS PORT) for which ERC will > always connect to using SSL. > 2. erc-use-ssl: If non-nill, all connections will be made using SSL. > 3. erc-ssl-blacklist: Alist of server ERC will connect to without SSL. > Only useful when erc-use-ssl is non-nil. > > erc-ssl-servers is also used to compute the initial port number > displayed on the minibuffer during user input when ERC is run > interactively. > All this extra code and complexity, for what exactly? You said it yourself, `erc-tls' is already there, it's even interactive! If you think it's not "prominent enough", one can certainly make it more prominent instead of producing the tangled mess that is your patch. Similar situations have led to ERC being bloated and messy as hell. John