From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless Date: Thu, 10 Jul 2014 03:20:56 -0400 Message-ID: References: <52D14E9F.5030001@gmx.at> <52D16627.4080604@gmx.at> <52D2661A.4000105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1404976880 891 80.91.229.3 (10 Jul 2014 07:21:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jul 2014 07:21:20 +0000 (UTC) Cc: 16038@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 10 09:21:09 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X58fF-00081a-Id for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jul 2014 09:21:09 +0200 Original-Received: from localhost ([::1]:36306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X58fE-0004qR-Vw for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jul 2014 03:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X58f9-0004pq-OI for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 03:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X58f8-0007FM-TK for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 03:21:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X58f8-0007FH-Pc for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 03:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X58f8-0006ca-Fx for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 03:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jul 2014 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16038 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16038-submit@debbugs.gnu.org id=B16038.140497686025437 (code B ref 16038); Thu, 10 Jul 2014 07:21:02 +0000 Original-Received: (at 16038) by debbugs.gnu.org; 10 Jul 2014 07:21:00 +0000 Original-Received: from localhost ([127.0.0.1]:51646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X58f5-0006cC-MY for submit@debbugs.gnu.org; Thu, 10 Jul 2014 03:21:00 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:38008 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X58f4-0006c4-14 for 16038@debbugs.gnu.org; Thu, 10 Jul 2014 03:20:58 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X58f2-0001WY-Sl; Thu, 10 Jul 2014 03:20:56 -0400 X-Spook: Reno doctrine halcon David John Oates Exon Shell Vickie X-Ran: 'v#W_P\3vSm,S@#h8gq\4#C/!lvo)./4Va (Leo Liu's message of "Wed, 09 Jul 2014 06:24:16 +0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91371 Archived-At: Leo Liu wrote: > On 2014-07-07 21:54 -0400, Glenn Morris wrote: > >> If you want to do this (I know you already did...), you need to add an >> incompatible change entry to NEWS about this, and you need to audit >> every single use of with-output-to-temp-buffer to find the ones that >> expected their output buffers to be in help mode. > > We made that change to prove the above two lines cause no harm other > than not enabling help-mode. At some stage and probably pretty soon, we > might merge the two macros with-output-to-temp-buffer and > with-temp-buffer-window under one name (the former looks like a simple > case of the latter). So the change is intermediate. Sorry, this makes no sense to me. with-output-to-temp-buffer is a documented macro with a specific purpose. I shall now do the tedious thing of quoting the manual: This function executes the forms in BODY while arranging to insert any output they print into the buffer named BUFFER-NAME, which is first created if necessary, and put into Help mode. [...] If the forms in BODY do not change the major mode in the output buffer, so that it is still Help mode at the end of their execution, then `with-output-to-temp-buffer' makes this buffer read-only at the end, and also scans it for function and variable names to make them into clickable cross-references. Now it does not do any of that. The normal way to do this kind of thing is to introduce a new macro that does whatever new thing you want, and deprecate the old one. Not to just half-arsedly change the old one to do something else, without updating any of the documentation or callers.