From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: comment-dwim on blank lines
Date: Thu, 01 Nov 2007 21:14:00 -0400 [thread overview]
Message-ID: <jwvzlxxih64.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <v1mytxcv1a.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu\, 01 Nov 2007 21\:09\:53 -0400")
> If comment-dwim is called on a non-blank line, it calls comment-indent
> to do the work of either inserting or indenting a comment. On a blank
> line, it does the work of inserting a new comment itself. Is there a
> reason for this difference in behaviour?
> It means that there isn't really any way for modes to customize what
> comment-dwim does on blank lines, other than by abusing
> indent-line-function. In particular, comment-insert-comment-function
> does not get called, which seems to contradict its doc-string.
It's clearly an oversight. comment-insert-comment-function was added due to
a specific need and whoever implemented didn't look at other related cases.
Feel free to fix it.
Stefan
next prev parent reply other threads:[~2007-11-02 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 1:09 comment-dwim on blank lines Glenn Morris
2007-11-02 1:14 ` Stefan Monnier [this message]
2007-11-02 1:47 ` Glenn Morris
2007-11-02 6:45 ` martin rudalics
2007-11-07 23:27 ` Glenn Morris
2007-11-22 3:08 ` Glenn Morris
2007-11-28 5:21 ` Glenn Morris
2007-11-28 9:15 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzlxxih64.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.