From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding parameters to windows Date: Wed, 04 Jun 2008 11:10:04 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212592261 3619 80.91.229.12 (4 Jun 2008 15:11:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2008 15:11:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 04 17:11:43 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3ueA-0001Zj-Rk for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 17:11:31 +0200 Original-Received: from localhost ([127.0.0.1]:53388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3udJ-0000k5-0X for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 11:10:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3udE-0000jz-JL for emacs-devel@gnu.org; Wed, 04 Jun 2008 11:10:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3udB-0000jn-MZ for emacs-devel@gnu.org; Wed, 04 Jun 2008 11:10:32 -0400 Original-Received: from [199.232.76.173] (port=48122 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3udB-0000jk-Gh for emacs-devel@gnu.org; Wed, 04 Jun 2008 11:10:29 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:49319) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3udA-0001C6-Fl for emacs-devel@gnu.org; Wed, 04 Jun 2008 11:10:29 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 3AD702CFA6C; Wed, 4 Jun 2008 11:10:20 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 82F4D3FE0; Wed, 4 Jun 2008 11:10:04 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 5BC5B41BEC; Wed, 4 Jun 2008 11:10:04 -0400 (EDT) In-Reply-To: (joakim@verona.se's message of "Wed, 04 Jun 2008 13:01:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98390 Archived-At: >> - I'd prefer to have `window-parameter' rather than `window-parameters'. I see you kept window-parameters around. That's fine, but I'm curious if there's a particular reason for it. Has it proved more useful than window-parameter in some circumtance? >> - The docstring of set-window-parameter needs to start with a capital >> letter and end with a "." and should mention its arguments. You forgot about that one. > (make_window): initialize window_parameters to nil Extra space after colon, lack of capital afterwards and lack of closing ".". > +It is a list of elements of the form (PARM . VALUE), where PARM is a symbol. Actually, nowhere is it enforced or even necessary for PARM to be a symbol (which is a good thing). Also better say PARAM than PARM. We can afford the extra chars after removing the comment about it being a symbol ;-) > + register struct window *w = decode_window (window); > + register Lisp_Object old_alist_elt; ^^^^^^^^ ;-) > + /* an alist with parameteres that modifies behaviour of certain window operations. Lack capitalization. Don't bother saying "that modifies behaviour of certain window operations": all the data in "struct window" has this property, by its very nature. This also has the added benefit of making it fit within 80 columns. > + */ We usually put this at the end of the last line of the comment rather than on its own line. Can someone fix up those things and commit this patch, please? And add a note to etc/NEWS about it? Stefan