From: Stefan Monnier <monnier@iro.umontreal.ca>
To: joakim@verona.se
Cc: emacs-devel@gnu.org
Subject: Re: Adding parameters to windows
Date: Wed, 04 Jun 2008 11:10:04 -0400 [thread overview]
Message-ID: <jwvzlq1w8fu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3lk1lv4yl.fsf@verona.se> (joakim@verona.se's message of "Wed, 04 Jun 2008 13:01:54 +0200")
>> - I'd prefer to have `window-parameter' rather than `window-parameters'.
I see you kept window-parameters around. That's fine, but I'm curious
if there's a particular reason for it. Has it proved more useful than
window-parameter in some circumtance?
>> - The docstring of set-window-parameter needs to start with a capital
>> letter and end with a "." and should mention its arguments.
You forgot about that one.
> (make_window): initialize window_parameters to nil
Extra space after colon, lack of capital afterwards and lack of closing ".".
> +It is a list of elements of the form (PARM . VALUE), where PARM is a symbol.
Actually, nowhere is it enforced or even necessary for PARM to be
a symbol (which is a good thing).
Also better say PARAM than PARM. We can afford the extra chars after
removing the comment about it being a symbol ;-)
> + register struct window *w = decode_window (window);
> + register Lisp_Object old_alist_elt;
^^^^^^^^
;-)
> + /* an alist with parameteres that modifies behaviour of certain window operations.
Lack capitalization. Don't bother saying "that modifies behaviour of
certain window operations": all the data in "struct window" has this
property, by its very nature. This also has the added benefit of making
it fit within 80 columns.
> + */
We usually put this at the end of the last line of the comment rather
than on its own line.
Can someone fix up those things and commit this patch, please?
And add a note to etc/NEWS about it?
Stefan
next prev parent reply other threads:[~2008-06-04 15:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 17:51 Adding parameters to windows Stefan Monnier
2008-05-23 14:10 ` joakim
2008-05-23 19:47 ` Stefan Monnier
2008-05-23 20:28 ` joakim
2008-06-04 11:01 ` joakim
2008-06-04 11:18 ` David Kastrup
2008-06-04 11:24 ` joakim
2008-06-04 11:46 ` David Kastrup
2008-06-04 15:10 ` Stefan Monnier [this message]
2008-06-04 15:58 ` joakim
2008-06-04 17:24 ` Stefan Monnier
2008-06-04 21:13 ` Juanma Barranquero
2008-06-04 21:25 ` joakim
2008-06-04 21:56 ` Juanma Barranquero
2008-06-04 22:05 ` joakim
2008-06-04 21:27 ` Juanma Barranquero
2008-06-05 2:07 ` Stefan Monnier
2008-06-05 3:25 ` Juanma Barranquero
-- strict thread matches above, loose matches on Subject: below --
2008-05-16 23:37 Seiji Zenitani
2008-05-20 1:17 ` Stefan Monnier
2008-06-03 9:04 ` Seiji Zenitani
2008-06-03 17:38 ` Glenn Morris
2008-06-04 6:46 ` Jan Djärv
2008-06-04 7:08 ` Glenn Morris
2008-06-04 9:10 ` Miles Bader
2008-06-05 1:45 ` Seiji Zenitani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzlq1w8fu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.