From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: byte-compile-nogroup-warn effectively disabled Date: Sun, 08 Jun 2008 21:55:29 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212976552 6443 80.91.229.12 (9 Jun 2008 01:55:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Jun 2008 01:55:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 09 03:56:34 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K5WcX-0007tI-70 for ged-emacs-devel@m.gmane.org; Mon, 09 Jun 2008 03:56:29 +0200 Original-Received: from localhost ([127.0.0.1]:37510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5Wbk-0000RU-5S for ged-emacs-devel@m.gmane.org; Sun, 08 Jun 2008 21:55:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5Wbf-0000Qc-D8 for emacs-devel@gnu.org; Sun, 08 Jun 2008 21:55:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5Wbe-0000QQ-2g for emacs-devel@gnu.org; Sun, 08 Jun 2008 21:55:35 -0400 Original-Received: from [199.232.76.173] (port=49090 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5Wbd-0000QN-Pk for emacs-devel@gnu.org; Sun, 08 Jun 2008 21:55:33 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:24495 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K5Wbb-0004NA-DE; Sun, 08 Jun 2008 21:55:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjICABcqTEjO+ISodGdsb2JhbACBVJA0ASebNQ X-IronPort-AV: E=Sophos;i="4.27,610,1204520400"; d="scan'208";a="22302175" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 08 Jun 2008 21:55:29 -0400 Original-Received: from pastel.home ([206.248.132.168]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id PHM11730; Sun, 08 Jun 2008 21:55:30 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8BBC18265; Sun, 8 Jun 2008 21:55:29 -0400 (EDT) In-Reply-To: (Richard M. Stallman's message of "Sun, 08 Jun 2008 18:06:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98752 Archived-At: > This change > ;; Warn if a custom definition fails to specify :group. > (defun byte-compile-nogroup-warn (form) > + (if (and (memq (car form) '(custom-declare-face custom-declare-variable)) > + byte-compile-current-group) > + ;; The group will be provided implicitly. > + nil > effectively defeats the point of that warning, which is to > make sure that every defcustom and defface specifies the group. I know it's your opinion, and I disagree. Even without an explicit :group, the defcustom will have a proper group attributed to it because it will use the last group defined in the file. So, in my opinion it fixes the warning so that it only occurs in cases where the lack of the :group really leads to the variable being associated to no group at all. Stefan