From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: VC commit missing ChangeLog message
Date: Wed, 12 Nov 2008 20:56:40 -0500 [thread overview]
Message-ID: <jwvzlk4s84f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86abc4fwfu.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 12 Nov 2008 15:47:49 -0600")
>>> I see your point and agree. How about this patch to just call
>>> log-edit-insert-changelog? I call it regardless of the SETUP parameter,
>>> but it could follow the erase-buffer call instead.
SM> I'd rather just change the default value of the hook, so that users can
SM> remove that entry from the hook if they don't want it run.
> Wait, the hook already calls it. For me it doesn't work, though (which
> is why I started this thread). Something is breaking in the changelog
> entry detection logic. It worked when I did C-c C-a (without C-u)
> manually. It must have been the logic that applies C-u if C-c C-a is
> called twice in a row; I must have hit the key twice without realizing
> it. So the problem is actually that the default logic doesn't detect my
> ChangeLog entry, not that log-edit-insert-changelog is not called. Argh.
It's probably the `setup' argument together with the
log-edit-invert-setup confg variable. It's rather messy and the main
purpose was to preserve 100% behavioral-compatibility while introducing
new features.
But I think I agree that the setup should simply always happen and the
user can then use the log-edit-hook to control what kind of setup he
wants to take place.
Stefan
next prev parent reply other threads:[~2008-11-13 1:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 14:41 VC commit missing ChangeLog message Ted Zlatanov
2008-11-11 14:49 ` Alfred M. Szmidt
2008-11-11 16:25 ` Stefan Monnier
2008-11-11 16:43 ` Ted Zlatanov
2008-11-11 16:58 ` Dan Nicolaescu
2008-11-11 19:11 ` Ted Zlatanov
2008-11-11 19:45 ` Dan Nicolaescu
2008-11-11 21:38 ` Ted Zlatanov
2008-11-12 1:11 ` Dan Nicolaescu
2008-11-12 17:17 ` Ted Zlatanov
2008-11-12 19:42 ` Stefan Monnier
2008-11-12 19:59 ` Dan Nicolaescu
2008-11-12 20:57 ` Stefan Monnier
2008-11-12 21:47 ` Ted Zlatanov
2008-11-13 1:56 ` Stefan Monnier [this message]
2008-11-12 19:56 ` Dan Nicolaescu
2008-11-12 21:42 ` Ted Zlatanov
2008-11-13 7:09 ` Dan Nicolaescu
2008-11-13 14:47 ` Ted Zlatanov
2008-11-13 15:12 ` Dan Nicolaescu
2008-11-12 2:38 ` Stefan Monnier
2008-11-11 17:41 ` Stefan Monnier
2008-11-11 19:09 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzlk4s84f.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.