Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

[Juanma Barranquero]

On Tue, Mar 10, 2009 at 15:09, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>        * emacsclient.c (main): Always pass cwd via "-dir".  Pass the file
>        names without prepending cwd to them, so Emacs uses its customary
>        rules to determine how to interpret the file name.

This change breaks useful Windows behavior.

Previously:

  C:\> g:
  G:\> cd test
  G:\test> c:
  C:\> emacsclient g:myfile.txt

opened g:\test\myfile.txt. Now it tries to open g:/myfile.txt.

The problem is that the "Emacs [...] customary rules to determine how
to interpret the file name" do not help, because the interpretation of
g:myfile.txt depends on the shell where you do run emacsclient (you
can perfectly have two different default directories in g: in
different shell invocations).

    Juanma

Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

[Stefan Monnier]

>>        * emacsclient.c (main): Always pass cwd via "-dir".  Pass the file
>>        names without prepending cwd to them, so Emacs uses its customary
>>        rules to determine how to interpret the file name.

> This change breaks useful Windows behavior.

> Previously:

>   C:\> g:
>   G:\> cd test
>   G:\test> c:
>   C:\> emacsclient g:myfile.txt

> opened g:\test\myfile.txt. Now it tries to open g:/myfile.txt.

> The problem is that the "Emacs [...] customary rules to determine how
> to interpret the file name" do not help, because the interpretation of
> g:myfile.txt depends on the shell where you do run emacsclient (you
> can perfectly have two different default directories in g: in
> different shell invocations).

Hmmm.... does the patch below help?  If so, please install it,


        Stefan


--- emacsclient.c.~1.155.~	2009-03-10 11:49:18.000000000 -0400
+++ emacsclient.c	2009-03-10 11:56:38.000000000 -0400
@@ -1635,6 +1635,26 @@
                   continue;
                 }
             }
+#ifdef WINDOWSNT
+	  else if (! file_name_absolute_p (argv[i])
+		   && (isalpha (argv[i][0]) && argv[i][1] == ':'))
+	    /* Windows can have a different default directory for each
+	       drive, so the cwd passed via "-dir" is not sufficient
+	       to account for that.
+	       If the user uses <drive>:<relpath>, we hence need to be
+	       careful to expand <relpath> with the default directory
+	       corresponding to <drive>.  */
+	    {
+	      char *filename = (char *) xmalloc (MAX_PATH);
+	      DWORD size;
+
+	      size = GetFullPathName (argv[i], MAX_PATH, filename, NULL);
+	      if (size > 0 && size < MAX_PATH)
+		argv[i] = filename;
+	      else
+		free (filename);
+	    }
+#endif
 
           send_to_emacs (emacs_socket, "-file ");
           quote_argument (emacs_socket, argv[i]);

Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

[Sebastian Rose]

Juanma Barranquero <lekktu@gmail.com> writes:
> On Tue, Mar 10, 2009 at 15:09, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>>        * emacsclient.c (main): Always pass cwd via "-dir".  Pass the file
>>        names without prepending cwd to them, so Emacs uses its customary
>>        rules to determine how to interpret the file name.
>
> This change breaks useful Windows behavior.
>
> Previously:
>
>   C:\> g:
>   G:\> cd test
>   G:\test> c:
>   C:\> emacsclient g:myfile.txt
>
> opened g:\test\myfile.txt. Now it tries to open g:/myfile.txt.
>
> The problem is that the "Emacs [...] customary rules to determine how
> to interpret the file name" do not help, because the interpretation of
> g:myfile.txt depends on the shell where you do run emacsclient (you
> can perfectly have two different default directories in g: in
> different shell invocations).
>
>     Juanma

I think that indeed emacsclient should behave like most other
applications do these days, and always request absolute filenames of the
form:

   Protocol://path/to/resource

(NOTE: no special OS dependend directory separator)
In your example:

   g:/myfile.txt

which is what you requested, but for another reason I believe.
`g:' should be considered a _protocol_ `g' and therefore map to
`g:/myfile'.

See rfc1738 section 2.1 for more on this.



If emacsclient finds a relative filename that is

  1.) not starting with a protocol
  2.) not starting with a slash

it should try to make it absolute and add the `file:' protocol.

That way emacsclient would become much more usefull, than it is now.



We can open `file:///home/sebastian/.emacs' through find-file, but not
through `emacsclient file:///home/sebastian/.emacs' which is a bug
IMHO.




Best regards,

-- 
Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449 Hannover
Tel.:  +49 (0)511 - 36 58 472
Fax:   +49 (0)1805 - 233633 - 11044
mobil: +49 (0)173 - 83 93 417
Email: s.rose@emma-stil.de, sebastian_rose@gmx.de
Http:  www.emma-stil.de

Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

[Juanma Barranquero]

On Tue, Mar 10, 2009 at 16:58, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Hmmm.... does the patch below help?  If so, please install it,

Yes. Applied.

Thanks,

    Juanma

Re: [Emacs-diffs] emacs lib-src/ChangeLog lib-src/emacsclient.c l...

[Stefan Monnier]

> We can open `file:///home/sebastian/.emacs' through find-file, but not
> through `emacsclient file:///home/sebastian/.emacs' which is a bug
> IMHO.

As mentioned in the parent of the article to which you replied,
"emacsclient file:///home/sebastian/.emacs" should now work,


        Stefan