From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Redundant if clause in xdisp.c? Date: Sat, 29 Aug 2009 17:21:42 -0400 Message-ID: References: <8363c6bxef.fsf@gnu.org> <834orqbjss.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251580950 18865 80.91.229.12 (29 Aug 2009 21:22:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 21:22:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 29 23:22:23 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhVNM-0005aD-07 for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 23:22:20 +0200 Original-Received: from localhost ([127.0.0.1]:36032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhVNL-0001rc-Br for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 17:22:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhVMu-0001eD-F5 for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:21:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhVMp-0001Xx-SU for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:21:52 -0400 Original-Received: from [199.232.76.173] (port=56467 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhVMp-0001XV-FF for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:21:47 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:44951 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhVMl-0006A5-RF; Sat, 29 Aug 2009 17:21:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmYFAO04mUpFpYuS/2dsb2JhbACBU9R1hBoFh2g X-IronPort-AV: E=Sophos;i="4.44,296,1249272000"; d="scan'208";a="44505717" Original-Received: from 69-165-139-146.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.146]) by ironport2-out.teksavvy.com with ESMTP; 29 Aug 2009 17:20:41 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6CDD37F42; Sat, 29 Aug 2009 17:21:42 -0400 (EDT) In-Reply-To: <834orqbjss.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Aug 2009 20:40:19 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114849 Archived-At: >> BTW, before playing with the redisplay, please just throw away >> keyboard.c's handling of self-insert-command, forward-char and >> backward-char, as well as the corresponding "direct-rendering >> fast-path" code. > These optimizations are disabled for bidi redisplay anyway, so they > don't bother me. Good. >> These optimizations seem to be pointless nowadays: even when running >> Emacs-23 on my cell-phone (FreeRunner) displaying on my desktop, they >> don't make any noticeable difference. > How did you turn them off to measure their influence, I removed the corresponding code. > and with what kind of stuff in your buffer(s)? I tried it in *scratch* and in a Python-mode buffer (visiting /usr/bin/zhone), doing random movement and typing (especially using the auto-repeat to see when the redisplay keeps up and when it doesn't). >> I refrained from installing this change for Emacs-23.2, out of fear >> bigfoot might come and bite me, but I'll definitely install it for >> Emacs-24. > OK, but for now I'd prefer not to do any changes in my bidi sandbox > that are not strictly related to bidirectional editing. Once we have > a way to commit these changes to CVS, fine with me, if we are sure > these optimizations don't matter anymore. Sure, I just wanted to make sure you don't waste time in these parts of the code. Stefan