bug#6060: 24.0.50; Process filters can no longer kill buffers

bug#6060: 24.0.50; Process filters can no longer kill buffers

[Helmut Eller]

When GNU Emacs 24.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.12.12) of
2010-04-28 executes code like this:

(defun filter-test ()
  (let* ((proc (start-process 
                "test" nil "/bin/bash" "-c" 
                "for i in 1 2 3 4 ; do echo $i ; sleep 1 ; done"))
         (buffer (generate-new-buffer "test-buffer"))
         (filter (lambda (proc str)
                   (message "filter: %S" str)
                   (kill-buffer buffer))))
    (set-process-filter proc filter)
    (unwind-protect
        (with-current-buffer buffer
          (while (buffer-live-p buffer)
            (accept-process-output proc)))
      (kill-process proc))))

Emacs signals this error:  (error "Selecting deleted buffer")

This used to work in earlier versions of Emacs.
The problem was most likely introduced by:

2010-04-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* process.c (exec_sentinel): Preserve current-buffer.

	* process.c (read_process_output): Move the save-current-buffer to
	apply to both the filter and the non-filter branches.

bug#6060: 24.0.50; Process filters can no longer kill buffers

[Stefan Monnier]

> Emacs signals this error:  (error "Selecting deleted buffer")
[...]
> This used to work in earlier versions of Emacs.
> The problem was most likely introduced by:
[...]
> 	* process.c (exec_sentinel): Preserve current-buffer.
> 	* process.c (read_process_output): Move the save-current-buffer to
> 	apply to both the filter and the non-filter branches.

Indeed, thank you.  I believe the patch below has fixed this, can you confirm?


        Stefan


=== modified file 'src/process.c'
--- src/process.c	2010-04-13 02:07:48 +0000
+++ src/process.c	2010-04-29 14:17:52 +0000
@@ -5396,7 +5396,7 @@
   /* There's no good reason to let process filters change the current
      buffer, and many callers of accept-process-output, sit-for, and
      friends don't expect current-buffer to be changed from under them.  */
-  record_unwind_protect (Fset_buffer, Fcurrent_buffer ());
+  record_unwind_protect (set_buffer_if_live, Fcurrent_buffer ());
 
   /* Read and dispose of the process output.  */
   outstream = p->filter;
@@ -6814,7 +6814,7 @@
   /* There's no good reason to let sentinels change the current
      buffer, and many callers of accept-process-output, sit-for, and
      friends don't expect current-buffer to be changed from under them.  */
-  record_unwind_protect (Fset_buffer, Fcurrent_buffer ());
+  record_unwind_protect (set_buffer_if_live, Fcurrent_buffer ());
 
   sentinel = p->sentinel;
   if (NILP (sentinel))

bug#6060: 24.0.50; Process filters can no longer kill buffers

[Helmut Eller]

* Stefan Monnier [2010-04-29 16:31+0200] writes:

>> Emacs signals this error:  (error "Selecting deleted buffer")
> [...]
>> This used to work in earlier versions of Emacs.
>> The problem was most likely introduced by:
> [...]
>> 	* process.c (exec_sentinel): Preserve current-buffer.
>> 	* process.c (read_process_output): Move the save-current-buffer to
>> 	apply to both the filter and the non-filter branches.
>
> Indeed, thank you.  I believe the patch below has fixed this, can you confirm?

Yes, works. Thanks for the quick fix.

Helmut

bug#6060: 24.0.50; Process filters can no longer kill buffers

[Stefan Monnier]

> Yes, works. Thanks for the quick fix.

Thanks for confirming,


        Stefan