From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: Juanma Barranquero <lekktu@gmail.com>, 6871@debbugs.gnu.org
Subject: bug#6871: Please make linum-mode per buffer, not per major mode
Date: Fri, 20 Aug 2010 14:59:09 +0200 [thread overview]
Message-ID: <jwvzkwhv49l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTimuWS8JaVkgvvniVtq1vFqcEF1_JcoPAxoh6v3-@mail.gmail.com> (Lennart Borgman's message of "Fri, 20 Aug 2010 03:11:21 +0200")
>>> Normally in my own code I just fix all the issues I see on the fly so
>>> to say. That is faster since I have already looked at the code then
>>> and knows what to do. Later (which may be much later) I might forget
>>> about exactly how to do it.
>> I have my own branch with a hodge-podge of changes in random order.
>> When I want to install a change from there to the trunk, I do a diff of
>> the relevant files and then pick the relevant parts and add
>> a ChangeLog message.
> Seems easiest, but I am not sure how to make the diff file.
By "I do a diff of the relevant files", I meant "bzr diff -rsubmit:
<files>", or rather C-u C-x v = s[TAB] RET RET.
By "pick the relevant parts", I meant:
- go to the *vc-diff* buffer
- M-x cd RET /my/checkout/of/the/trunk RET
- apply C-c C-a to the hunks I want to pick
- edit to clean up, improve, ...
- save the modified files.
- do C-x v = on the modified files, to see the patch I'm about to commit
to trunk (or to send it via email).
> I just edited the diff file I had. Does this work,
Depends if you edited it well or not.
> i.e. how does the program patch handle this?
Again, depends if you edited it correctly or not. Have you tried it?
> I have attached a patch done this way for just making linum-mode per
> buffer instead of per major mode.
Have you tried the patch and confirmed that it works and fixes
your problem? I see it lacks the removal of change-major-mode-hook.
Stefan
next prev parent reply other threads:[~2010-08-20 12:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 2:06 bug#6871: Please make linum-mode per buffer, not per major mode Lennart Borgman
2010-08-17 8:59 ` Stefan Monnier
2010-08-17 11:23 ` Lennart Borgman
2010-08-17 12:11 ` Stefan Monnier
2010-08-17 12:35 ` Lennart Borgman
2010-08-18 7:19 ` Stefan Monnier
2010-08-19 4:29 ` Lennart Borgman
2010-08-19 12:13 ` Juanma Barranquero
2010-08-19 13:25 ` Lennart Borgman
2010-08-19 13:38 ` Juanma Barranquero
2010-08-19 14:00 ` Lennart Borgman
2010-08-19 14:40 ` Juanma Barranquero
2010-08-19 21:23 ` Lennart Borgman
2010-08-19 21:57 ` Juanma Barranquero
2010-08-19 22:21 ` Lennart Borgman
2010-08-20 9:05 ` Eli Zaretskii
2010-08-19 22:43 ` Stefan Monnier
2010-08-20 1:11 ` Lennart Borgman
2010-08-20 12:59 ` Stefan Monnier [this message]
2010-08-19 14:45 ` Stefan Monnier
2010-08-19 21:19 ` Lennart Borgman
2010-08-17 23:47 ` MON KEY
2010-08-18 0:14 ` Lennart Borgman
2010-08-18 7:20 ` Stefan Monnier
2010-08-19 17:49 ` MON KEY
2010-08-19 21:18 ` Lennart Borgman
2020-09-19 15:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzkwhv49l.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6871@debbugs.gnu.org \
--cc=lekktu@gmail.com \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.