From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tim Van Holder <tim.vanholder@gmail.com>
Cc: 7215@debbugs.gnu.org
Subject: bug#7215: 24.0.50; Minibuffer path completion mispositions point
Date: Mon, 18 Oct 2010 10:24:24 -0400 [thread overview]
Message-ID: <jwvzkubwpju.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTikZyb2WJ+rq6nJwpwCYqoRZNkKop1Ne3s651p5i@mail.gmail.com> (Tim Van Holder's message of "Mon, 18 Oct 2010 08:56:55 +0200")
>> I've installed the patch below into the emacs-23 branch. This should
>> fix the problem. Please confirm,
> I'm on trunk, not the emacs-23 branch.
Yes, but the bug was there as well. It'll get merged into trunk in due time.
> However, I (manually) applied the same change to trunk and the problem
> did indeed go away.
Thank you for confirming.
> Does mark matter in the minibuffer?
Yes.
> If so, perhaps it should be forward-char-nomark?
forward-char is a low-level function which does not touch the mark.
forward-char-nomark OTOH is a command (only defined if you load
pc-select.el) which does affect the mark. So `forward-char' is what we
want here.
> Note: the diff you posted seems to ignore whitespace, which made it
> slightly harder to twig that you were extending the let, because the
> goto-char and indent didn't change their indentation.
It's a tradeoff: OT1H you don't see that the indentation changed, but
OTOH you do see that this part of the code has not been modified.
Stefan
next prev parent reply other threads:[~2010-10-18 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 13:22 bug#7215: 24.0.50; Minibuffer path completion mispositions point Tim Van Holder
2010-10-15 14:08 ` Stephen Berman
2010-10-17 17:31 ` Stefan Monnier
2010-10-18 6:56 ` Tim Van Holder
2010-10-18 14:24 ` Stefan Monnier [this message]
2010-10-18 20:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzkubwpju.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7215@debbugs.gnu.org \
--cc=tim.vanholder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.