From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among Date: Wed, 27 Oct 2010 21:13:25 -0400 Message-ID: References: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk> <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288228416 20031 80.91.229.12 (28 Oct 2010 01:13:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Oct 2010 01:13:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Jes Bodi Klinke" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 28 03:13:35 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBH3e-0005zX-JF for ged-emacs-devel@m.gmane.org; Thu, 28 Oct 2010 03:13:34 +0200 Original-Received: from localhost ([127.0.0.1]:39124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBH3d-0004fQ-Tz for ged-emacs-devel@m.gmane.org; Wed, 27 Oct 2010 21:13:33 -0400 Original-Received: from [140.186.70.92] (port=39826 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBH3Y-0004e8-7P for emacs-devel@gnu.org; Wed, 27 Oct 2010 21:13:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBH3X-0000mV-6E for emacs-devel@gnu.org; Wed, 27 Oct 2010 21:13:28 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:48279 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBH3X-0000mH-40 for emacs-devel@gnu.org; Wed, 27 Oct 2010 21:13:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgQJAPtqyExFxL/T/2dsb2JhbACgSHxywFCFSASSKg X-IronPort-AV: E=Sophos;i="4.58,248,1286164800"; d="scan'208";a="80870287" Original-Received: from 69-196-191-211.dsl.teksavvy.com (HELO pastel.home) ([69.196.191.211]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 27 Oct 2010 21:13:26 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id BE7FDA8558; Wed, 27 Oct 2010 21:13:25 -0400 (EDT) In-Reply-To: <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> (Jes Bodi Klinke's message of "Wed, 27 Oct 2010 14:37:09 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132152 Archived-At: > (by adding an outer pair of parentheses). The correct regex is: > " -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)" Thanks, installed. But, could you tell me how you made your patches? Neither diff-mode nor `patch' understand their format: > *** lisp/progmodes/compile.el 2010-09-24 03:06:33 +0000 > --- lisp/progmodes/compile.el 2010-10-27 21:30:57 +0000 > *** 543,549 **** > ;; Command output lines. Recognize `make[n]:' lines too. Usually such context diffs have an additional "***************" line as in: > *** lisp/progmodes/compile.el 2010-09-24 03:06:33 +0000 > --- lisp/progmodes/compile.el 2010-10-27 21:30:57 +0000 > *************** > *** 543,549 **** > ;; Command output lines. Recognize `make[n]:' lines too. Stefan