bug#8416: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions

bug#8416: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions

[Jari Aalto]

Package: emacs
Version: 23.2+1-7
Severity: wishlist

It would be nice if the define-minor-mode would also define functions:

    turn-on-*
    turn-off-*

An example:

    ;; lisp/hl-line.el
    (define-minor-mode hl-line-mode ...)

That would make it possible to add to ~/.emacs:

    (add-hook 'nroff-mode-hook 'turn-on-hl-line-mode)

    ;; Or later:
    (remove-hook 'nroff-mode-hook 'turn-on-hl-line-mode)

This would be much more cleaner than what is needed now:

    (add-hook 'nroff-mode-hook '(lambda () (turn-on-hl-line-mode 1)))
    ...
    ;; the hook removal command is as messy


-- System Information
Debian Release: wheezy/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-7        GNU Emacs is the extensible self-documenting
emacs23-lucid   23.2+1-7        GNU Emacs is the extensible self-documenting
emacs23-nox     23.2+1-7        GNU Emacs is the extensible self-documenting

bug#8416: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions

[Glenn Morris]

Jari Aalto wrote:

> It would be nice if the define-minor-mode would also define functions:
>
>     turn-on-*
>     turn-off-*

You've proposed this kind of thing before, and it has been rejected.

http://debbugs.gnu.org/cgi/bugreport.cgi?msg=9;bug=4288

  "...I don't like the turn-on-* and turn-off-* functions: we have
  already the *-mode functions which should be plenty."

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7709#8

  "There is no need for it (and neither is there a need for
  turn-on-eldoc-mode). There is M-x eldoc-mode."

bug#8416: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions

[Stefan Monnier]

> It would be nice if the define-minor-mode would also define functions:

>     turn-on-*
>     turn-off-*

In Emacs-24, the `foo-mode' function of a minor mode *is* the
turn-on-foo-mode function (at least when called non-interactively
without an argument, e.g. on a normal hook).

> This would be much more cleaner than what is needed now:
>     (add-hook 'nroff-mode-hook '(lambda () (turn-on-hl-line-mode 1)))

As mentioned, the above is not needed any more:

  (add-hook 'nroff-mode-hook 'hl-line-mode)

will work just fine.

The turn-off-foo is rarely needed in my experience.


        Stefan