From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11378: 24.1.50; Suggestion: Let M-i in isearch cycle `search-invisible' Date: Sun, 29 Apr 2012 10:46:37 -0400 Message-ID: References: <87haw32hly.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335710880 14154 80.91.229.3 (29 Apr 2012 14:48:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 29 Apr 2012 14:48:00 +0000 (UTC) Cc: 11378@debbugs.gnu.org To: michael_heerdegen@web.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 29 16:47:59 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SOVPq-0008C7-HK for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Apr 2012 16:47:58 +0200 Original-Received: from localhost ([::1]:40999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOVPp-00021C-Tx for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Apr 2012 10:47:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOVPn-00020t-1i for bug-gnu-emacs@gnu.org; Sun, 29 Apr 2012 10:47:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOVPl-0000hs-CZ for bug-gnu-emacs@gnu.org; Sun, 29 Apr 2012 10:47:54 -0400 Original-Received: from [140.186.70.43] (port=56835 helo=debbugs.gnu.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOVPl-0000hV-99 for bug-gnu-emacs@gnu.org; Sun, 29 Apr 2012 10:47:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SOVQs-0000UV-Nd for bug-gnu-emacs@gnu.org; Sun, 29 Apr 2012 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Apr 2012 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11378-submit@debbugs.gnu.org id=B11378.13357108821813 (code B ref 11378); Sun, 29 Apr 2012 14:49:02 +0000 Original-Received: (at 11378) by debbugs.gnu.org; 29 Apr 2012 14:48:02 +0000 Original-Received: from localhost ([127.0.0.1]:57869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOVPr-0000Sx-Sq for submit@debbugs.gnu.org; Sun, 29 Apr 2012 10:48:02 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41040) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOVPo-0000So-0J for 11378@debbugs.gnu.org; Sun, 29 Apr 2012 10:47:57 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q3TEkcQd021697; Sun, 29 Apr 2012 10:46:38 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 17870AE113; Sun, 29 Apr 2012 10:46:37 -0400 (EDT) In-Reply-To: <87haw32hly.fsf@web.de> (Michael Heerdegen's message of "Sun, 29 Apr 2012 08:10:33 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4206=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4206> : streams <751253> : uri <1105174> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59623 Archived-At: > (defun isearch-cycle-search-invisible () > "Cycle the value of `search-invisible'. > Bound to \\\\[isearch-cycle-search-invisible] in `isearch'." > (interactive) > (setq search-invisible > (case search-invisible > ((nil) t) > ((t) 'open) > (else nil))) I personally find the "search within hidden text without opening it" to be a completely useless option, so I couldn't want to cycle between all 3 options, but only between nil and `open'. > (define-key isearch-mode-map [?\M-i] > 'isearch-cycle-search-invisible) You'll have to place it in the M-s prefix map instead, which was setup specifically to avoid eating up more key combinations which currently make isearch exit. > So, it would be good if the user could change the value of > `search-invisible' as well directly from isearch. I'm not sure I'd find it useful, but I can imagine some people might like it and there's plenty of room under the M-s prefix for such a thing. So if you can address the above two comments, and provide the result as a patch against isearch.el, we can install it. Stefan