From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10181: 24.0.92; [wishlist] split `diff-refine-change' in several faces Date: Wed, 23 May 2012 09:53:09 -0400 Message-ID: References: <87txzftzn0.fsf@mail.jurta.org> <87396yxr9u.fsf@mail.jurta.org> <87d361w2ea.fsf@mail.jurta.org> <87aa13k9o1.fsf@mail.jurta.org> <87k406uz7n.fsf@mail.jurta.org> <878vgj7k6l.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337781270 21873 80.91.229.3 (23 May 2012 13:54:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 May 2012 13:54:30 +0000 (UTC) Cc: 10181@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 15:54:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SXC1A-00089D-Cr for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 15:54:24 +0200 Original-Received: from localhost ([::1]:54107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXC16-0000bN-UH for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 09:54:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXC14-0000bE-0c for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 09:54:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXC0z-0006h2-9z for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 09:54:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXC0z-0006gx-6R for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 09:54:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SXC1m-00041M-0W for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 09:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2012 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10181 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10181-submit@debbugs.gnu.org id=B10181.133778124715388 (code B ref 10181); Wed, 23 May 2012 13:55:01 +0000 Original-Received: (at 10181) by debbugs.gnu.org; 23 May 2012 13:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:40513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXC0t-000408-Bw for submit@debbugs.gnu.org; Wed, 23 May 2012 09:54:07 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:30726) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXC0r-0003zf-9F for 10181@debbugs.gnu.org; Wed, 23 May 2012 09:54:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09MCpYd/2dsb2JhbABEsEiDSYEIghYBBVYjEAs0EhQYDSSIIboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="181963103" Original-Received: from 76-10-150-29.dsl.teksavvy.com (HELO pastel.home) ([76.10.150.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 May 2012 09:53:09 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 843F259460; Wed, 23 May 2012 09:53:09 -0400 (EDT) In-Reply-To: <878vgj7k6l.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 23 May 2012 03:36:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60302 Archived-At: >>> + (if (not (or (face-equal diff-changed-face diff-added-face) >>> + (face-equal diff-changed-face diff-removed-face))) >> Please introduce a defvar for it, so we don't re-evaluate the face >> comparison for each and every line. > This defvar needs to be re-evaluated when the user customized faces. Which rarely happens after loading diff-mode.el, so I wouldn't worry about it. That also lets the user set the variable explicitly if she wants to (after all, the faces can be different in one frame but equal in another, so the above test is not 100% foolproof anyway). The rest of the patch looks OK, Stefan