From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juri Linkov <juri@jurta.org>
Cc: 12107@debbugs.gnu.org
Subject: bug#12107: 24.1.50; In Info mode, add the name of the manual as completion candidate for "bookmark-set"
Date: Wed, 01 Aug 2012 20:10:04 -0400 [thread overview]
Message-ID: <jwvzk6e17fy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87obmudymn.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 02 Aug 2012 02:04:48 +0300")
> - (default (car record)))
> + (defaults (bookmark-prop-get record 'defaults))
> + (default (if (consp defaults) (car defaults) defaults)))
> +
> + (if defaults
> + ;; Don't store default values in the record.
> + (setq record (assq-delete-all 'defaults record))
> + ;; When no defaults in the record, use its first element.
> + (setq defaults (car record) default defaults))
Is there a good reason why we can't use a list in (car record) and avoid
using a new `defaults' field?
If so, please add a comment explaining it.
Stefan
next prev parent reply other threads:[~2012-08-02 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 20:22 bug#12107: 24.1.50; In Info mode, add the name of the manual as completion candidate for "bookmark-set" Dani Moncayo
2012-08-01 0:12 ` Juri Linkov
2012-08-01 1:09 ` Dani Moncayo
2012-08-01 8:19 ` Juri Linkov
2012-08-01 9:16 ` Dani Moncayo
2012-08-01 20:35 ` Stefan Monnier
2012-08-01 23:04 ` Juri Linkov
2012-08-02 0:10 ` Stefan Monnier [this message]
2012-08-02 8:03 ` Juri Linkov
2012-08-05 0:01 ` Juri Linkov
2012-08-08 8:49 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzk6e17fy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12107@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.