From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Ryan Crum <ryan.j.crum@gmail.com>
Cc: 12634@debbugs.gnu.org
Subject: bug#12634: Patch for pretty-printing in json.el
Date: Thu, 25 Oct 2012 14:08:59 -0400 [thread overview]
Message-ID: <jwvzk3a8mv0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAMiu-qD6-eCYvabbj9zsxFmrotu1vRBacozU4v8bUNaESNuB-Q@mail.gmail.com> (Ryan Crum's message of "Thu, 25 Oct 2012 10:55:39 -0400")
> I've consolidated my changes into json.el. I have not yet received
> the form for copyright assignment in the mail, but I have
> requested it.
Great, thanks.
> Please advise me if you'd like me to make any changes here, and I'll
> be happy to accomodate. Patch attached.
It looks OK overall, but I do have some comments:
- it would be better not to re-compute json-encoding-current-separator
every time we call json-encode, since that function is called all
the time.
IOW, build it once in an external caller. Or better yet: get rid of
json-encoding-current-separator and add a "\n" at the beginning of
json-encoding-current-indentation instead.
- you can use the "json--" prefix to indicate it is an internal
variable/function.
- You could also prefer to place the closing ] at the end of the
previous line, à la Lisp ;-)
Stefan
next prev parent reply other threads:[~2012-10-25 18:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 8:39 bug#12634: 24.2; [FEATURE REQUEST] JSON pretty printer Leo
2012-10-13 21:56 ` Stefan Monnier
2012-10-18 21:18 ` bug#12634: existing implementation Aurélien Aptel
2012-10-19 1:37 ` Stefan Monnier
2012-10-19 16:20 ` Aurélien Aptel
2012-10-19 18:04 ` Stefan Monnier
2012-10-19 21:28 ` Stefan Monnier
2012-10-25 14:55 ` bug#12634: Patch for pretty-printing in json.el Ryan Crum
2012-10-25 18:08 ` Stefan Monnier [this message]
2012-10-27 19:31 ` Ryan Crum
2012-10-30 20:03 ` Stefan Monnier
2012-10-30 21:04 ` Ryan Crum
2012-11-15 1:56 ` Stefan Monnier
2012-11-17 17:37 ` Ryan Crum
2012-11-20 18:52 ` Stefan Monnier
2012-11-27 23:15 ` Ryan Crum
2012-12-14 2:56 ` bug#12634: Patch Ryan Crum
2012-12-14 14:59 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzk3a8mv0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12634@debbugs.gnu.org \
--cc=ryan.j.crum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.