getting the same indentation as flet

getting the same indentation as flet

[Nic Ferrier]

I've written an flet like macro and I'd really like flet like
indentation support for it.

How can I achieve that? Is it achievable just in the macro definition?

I note that the current flet macros (including the new cl- ones) do not
have complex indent declarations to specify how the bindings are to be
indented.

What would be ideal, for macro writing, is if we could declare, not only
`defun' indentation but `let' or `flet' indentation.

Anyone got any clues as to whether that would be possible? I wouldn't
mind looking at doing it if it's doable.


Nic

Re: getting the same indentation as flet

[Nic Ferrier]

Sorry! It's actually quite easy to get done:

  (setplist 'some-flet-sym (symbol-plist 'flet))

I still wonder if this couldn't be done via declare, like `defun' is.

Re: getting the same indentation as flet

[Stefan Monnier]

> I've written an flet like macro and I'd really like flet like
> indentation support for it.

The `flet' indentation specification is: 1
So you can just use that, as in

   (defmacro my-flet (blabla)
     (declare (indent 1))
     ...)

> How can I achieve that? Is it achievable just in the macro definition?

See above.

> I note that the current flet macros (including the new cl- ones) do not
> have complex indent declarations to specify how the bindings are to be
> indented.

Indeed, the specification is very primitive.


        Stefan

Re: getting the same indentation as flet

[Nic Ferrier]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The `flet' indentation specification is: 1
> So you can just use that, as in
>
>    (defmacro my-flet (blabla)
>      (declare (indent 1))
>      ...)

That isn't the flet specification. It may be the cl-flet specification
but the flet specification I have is:

 (lisp-indent-function 1 edebug-form-spec cl-flet 
    byte-obsolete-info ("use either `cl-flet' or `cl-letf'." nil "24.3") 
    common-lisp-indent-function 
     ((&whole 4 &rest (&whole 1 &lambda &body)) &body))

I  guess that's because I've configured common-lisp indent functionality
but I  think the elisp one is similarly good.

cl-flet has no identation. That's just another reason that cl-flet is
not very good.


Nic

Re: getting the same indentation as flet

[Stefan Monnier]

> That isn't the flet specification. It may be the cl-flet specification
> but the flet specification I have is:

>  (lisp-indent-function 1 edebug-form-spec cl-flet 
>     byte-obsolete-info ("use either `cl-flet' or `cl-letf'." nil "24.3") 
>     common-lisp-indent-function 
>      ((&whole 4 &rest (&whole 1 &lambda &body)) &body))

"lisp-indent-function 1" is the part that affects Elisp indentation.

> I  guess that's because I've configured common-lisp indent functionality
> but I  think the elisp one is similarly good.

"common-lisp-indent-function ((&whole 4 &rest (&whole 1 &lambda &body)) &body)"
is the part that affects cl-indent, IIUC, indeed.

> cl-flet has no identation. That's just another reason that cl-flet is
> not very good.

Patches welcome,


        Stefan

Re: getting the same indentation as flet

[Nic Ferrier]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> That isn't the flet specification. It may be the cl-flet specification
>> but the flet specification I have is:
>
>>  (lisp-indent-function 1 edebug-form-spec cl-flet 
>>     byte-obsolete-info ("use either `cl-flet' or `cl-letf'." nil "24.3") 
>>     common-lisp-indent-function 
>>      ((&whole 4 &rest (&whole 1 &lambda &body)) &body))
>
> "lisp-indent-function 1" is the part that affects Elisp indentation.
>
>> I  guess that's because I've configured common-lisp indent functionality
>> but I  think the elisp one is similarly good.
>
> "common-lisp-indent-function ((&whole 4 &rest (&whole 1 &lambda &body)) &body)"
> is the part that affects cl-indent, IIUC, indeed.
>
>> cl-flet has no identation. That's just another reason that cl-flet is
>> not very good.
>
> Patches welcome,

I doubt you'd accept a patch to make cl-flet back into something that is
dynamically bound (which is what I care about with cl-flet).

But here's the trivial patch for the cl-flet indentation:

diff -c -L /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/cl-macs.el.gz.\~1\~ -L /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/cl-macs.el.gz /tmp/jka-com8047btu /tmp/jka-com8047aBE
*** /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/cl-macs.el.gz.~1~
--- /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/cl-macs.el.gz
***************
*** 1657,1663 ****
  Like `cl-labels' but the definitions are not recursive.
  
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
!   (declare (indent 1) (debug ((&rest (cl-defun)) cl-declarations body)))
    (let ((binds ()) (newenv macroexpand-all-environment))
      (dolist (binding bindings)
        (let ((var (make-symbol (format "--cl-%s--" (car binding)))))
--- 1657,1664 ----
  Like `cl-labels' but the definitions are not recursive.
  
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
!   (declare (indent ((&whole 4 &rest (&whole 1 &lambda &body)) &body))
!            (debug ((&rest (cl-defun)) cl-declarations body)))
    (let ((binds ()) (newenv macroexpand-all-environment))
      (dolist (binding bindings)
        (let ((var (make-symbol (format "--cl-%s--" (car binding)))))

Diff finished.  Mon Jun  3 09:58:56 2013

Re: getting the same indentation as flet

[Stefan Monnier]

> !   (declare (indent ((&whole 4 &rest (&whole 1 &lambda &body)) &body))
> !            (debug ((&rest (cl-defun)) cl-declarations body)))

 "Invalid function ((&whole 4 &rest (&whole 1 &lambda &body)) &body)"

It needs to work also when cl-indent is not loaded.


        Stefan