all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: Simple lisp-tests.el and commit privs
Date: Tue, 20 Aug 2013 01:23:42 -0400	[thread overview]
Message-ID: <jwvzjsdos35.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAFM41H2nO_p9pgWiNaAfViNyCe3CtCd8gtZxH3-=kjC+LAgHyg@mail.gmail.com> (Barry OReilly's message of "Mon, 19 Aug 2013 12:41:20 -0400")

>>> It looks like the test/indent tests are only good for null-diff
>>> general indentation rules.
>> What makes you think so?
> When the diff outputs differences (ie a non null-diff), how does the
> current test/indent distinguish expected from unexpected? If there
> was a test/indent/ruby.rb.expected file (for example), then I could
> see how it could do so: 'diff ruby.rb.expected ruby.rb.new' returns
> nothing.

Oh, you're referring to known indentation problems, where you want to
have the test but have it be marked as "expected".

Yes, that's currently not really supported: I try to put "FIXME" on
the corresponding lines, but very often an incorrect indentation on one
line impact subsequent lines as well, so not only does the "diff" not
care about those FIXME markers, but you can get false positives or false
negatives to boot.


        Stefan



  reply	other threads:[~2013-08-20  5:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21  4:12 Simple lisp-tests.el and commit privs Barry OReilly
2013-07-21 23:08 ` Xue Fuqiao
2013-07-25 19:09 ` Stefan Monnier
2013-08-14 17:49   ` Barry OReilly
2013-08-14 21:23     ` Dmitry Gutov
2013-08-18 22:05       ` Barry OReilly
2013-08-19  3:06         ` Stefan Monnier
2013-08-19  3:09         ` Stefan Monnier
2013-08-19 16:41           ` Barry OReilly
2013-08-20  5:23             ` Stefan Monnier [this message]
2013-08-20 16:04               ` Barry OReilly
2013-08-20 20:54                 ` Stefan Monnier
2013-08-21 23:06                   ` Barry OReilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzjsdos35.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=gundaetiapo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.