all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 15294@debbugs.gnu.org
Subject: bug#15294: 24.3.50; js2-mode parser is several times slower in lexical-binding mode
Date: Mon, 09 Sep 2013 22:04:38 -0400	[thread overview]
Message-ID: <jwvzjrly386.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871u51ll93.fsf@yandex.ru> (Dmitry Gutov's message of "Fri, 06 Sep 2013 23:59:20 +0300")

> If I append -*- lexical-binding: t -*- to the first line of js2-mode.el
> and eval the buffer, parsing a file takes several (3 to 4) times longer.

[ I'm disregarding the interpreted time for now, since the issues are
  likely to be different. ]

In the compiled case, loading js2-mode-lexical.elc and then redefining
`js2-get-token' to the value it has in js2-mode-dynamic.elc brings me
back the same speed as with js2-mode-dynamic.elc.
IOW the slowdown is in js2-get-token.

If it indeed comes from the handling of catch/throw, then there are two
ways to fix it:
- provide a new byte-code for catch which does not require wrapping the
  body in a closure.  This should not be terribly difficult and would
  benefit all existing code, but it does require changes to the way
  catch is implemented.
- improve the byte-compiler so it can compile away cl-block/cl-return.
  This should not require new byte-codes, but requires delving "deepish"
  into the byte-compiler.


        Stefan





  parent reply	other threads:[~2013-09-10  2:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 20:59 bug#15294: 24.3.50; js2-mode parser is several times slower in lexical-binding mode Dmitry Gutov
2013-09-06 23:44 ` Xue Fuqiao
2013-09-07  3:15   ` Stefan Monnier
2013-09-08 22:32 ` Stefan Monnier
2013-09-10  2:04 ` Stefan Monnier [this message]
2013-09-13  3:40   ` Stefan Monnier
2013-09-13  3:59     ` Drew Adams
2013-09-13  4:37       ` Stefan Monnier
2013-09-13  5:45         ` Drew Adams
2013-09-13 13:01           ` Stefan Monnier
2013-09-14  0:09         ` Lexical let and setq Michael Welsh Duggan
2013-09-14  3:46           ` Stefan Monnier
2013-09-14 11:13             ` Lars Magne Ingebrigtsen
2013-09-14 14:04               ` Pascal J. Bourguignon
2013-09-15  5:11               ` Stefan Monnier
2013-09-14 21:47           ` Richard Stallman
2013-09-15  5:09             ` Stefan Monnier
2013-09-15 16:54               ` Richard Stallman
2013-09-15 17:06                 ` Stefan Monnier
2013-09-16 10:47                   ` Richard Stallman
2013-09-14  4:20     ` bug#15294: 24.3.50; js2-mode parser is several times slower in lexical-binding mode Dmitry Gutov
2013-09-14 14:27       ` Stefan Monnier
2013-09-15  0:11         ` Dmitry Gutov
2013-09-15  5:04           ` Stefan Monnier
2013-09-15 16:54           ` Richard Stallman
2013-09-15  0:24   ` Dmitry Gutov
2013-09-15  5:06     ` Stefan Monnier
2013-09-18 23:48   ` Stefan Monnier
2013-09-22  4:56     ` Dmitry Gutov
2013-10-03  5:00       ` Stefan Monnier
2013-10-04  2:38         ` Dmitry Gutov
2013-10-04 13:52           ` Stefan Monnier
2013-10-05  3:27             ` Dmitry Gutov
2014-12-14 12:31             ` Dmitry Gutov
2014-12-14 14:08               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzjrly386.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=15294@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.