From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Fri, 29 Nov 2013 08:33:46 -0500 Message-ID: References: <871u1zes89.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385732045 32416 80.91.229.3 (29 Nov 2013 13:34:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 13:34:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 14:34:10 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmOCr-0004Zo-G6 for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 14:34:05 +0100 Original-Received: from localhost ([::1]:47353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmOCq-0003qs-R6 for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 08:34:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmOCh-0003lb-Aj for emacs-devel@gnu.org; Fri, 29 Nov 2013 08:34:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmOCa-0002hu-0n for emacs-devel@gnu.org; Fri, 29 Nov 2013 08:33:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:33828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmOCZ-0002hq-T0 for emacs-devel@gnu.org; Fri, 29 Nov 2013 08:33:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40678093" Original-Received: from 206-248-161-33.dsl.teksavvy.com (HELO pastel.home) ([206.248.161.33]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Nov 2013 08:33:46 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 53EE560EFA; Fri, 29 Nov 2013 08:33:46 -0500 (EST) In-Reply-To: <871u1zes89.fsf@yandex.ru> (Dmitry Gutov's message of "Fri, 29 Nov 2013 06:39:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165867 Archived-At: > 1. The "Author" header will be almost always unused in other projects, > aside from Emacs, I'm contributing to. So it'll stick out like a sore > thumb. And even with Emacs, when the ChangeLog entry has the proper > author mentioned, it's auto-filled anyway. The intention was to remind people that they should think about who's the author. Indeed, it's particularly useful for us but less so for many other projects. Maybe we can set it as a .dir-locals.el customization. > 2. The "Summary" doesn't add anything in the way of features, I can just > as well write it in the first line of the message. The RFC822 format does add features, since there are a few other special headers (Author, Fixes, Amend, maybe a few more). > When the buffer is displayed initially, the point is before "Summary:", > so now I have to move it first before I can write the commit message. Indeed that's a bug. If someone can fix that, that's be very welcome. We should also use some of the message-mode commands to move inside the header, as was suggested here recently. > `vc-git-log-edit-toggle-amend' is not aware of this header and inserts > the whole message, summary and the rest, below the headers, leaving > "Summary" empty. Although this should be fixable. Sounds like a bug, indeed. > 3. If I decide I don't want to commit now, and I kill the log-edit > buffer (is there any other way to dismiss it?), the window and buffer > created by `log-edit-show-files', doesn't go anywhere, and I have to > take care of it separately. Also fixable. Indeed, that needs to be fixed. It's easy to fix when we kill the *vc-log* buffer, but it might be trickier to fix when you just bury-it :-( Maybe log-edit-show-files shouldn't be in the default log-edit-hook. Stefan