all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.
Date: Fri, 29 Nov 2013 08:33:46 -0500	[thread overview]
Message-ID: <jwvzjone3vy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871u1zes89.fsf@yandex.ru> (Dmitry Gutov's message of "Fri, 29 Nov 2013 06:39:50 +0200")

> 1. The "Author" header will be almost always unused in other projects,
> aside from Emacs, I'm contributing to. So it'll stick out like a sore
> thumb. And even with Emacs, when the ChangeLog entry has the proper
> author mentioned, it's auto-filled anyway.

The intention was to remind people that they should think about who's
the author.  Indeed, it's particularly useful for us but less so for
many other projects.  Maybe we can set it as a .dir-locals.el customization.

> 2. The "Summary" doesn't add anything in the way of features, I can just
> as well write it in the first line of the message.

The RFC822 format does add features, since there are a few other special
headers (Author, Fixes, Amend, maybe a few more).

> When the buffer is displayed initially, the point is before "Summary:",
> so now I have to move it first before I can write the commit message.

Indeed that's a bug.  If someone can fix that, that's be very welcome.

We should also use some of the message-mode commands to move inside the
header, as was suggested here recently.

> `vc-git-log-edit-toggle-amend' is not aware of this header and inserts
> the whole message, summary and the rest, below the headers, leaving
> "Summary" empty. Although this should be fixable.

Sounds like a bug, indeed.

> 3. If I decide I don't want to commit now, and I kill the log-edit
> buffer (is there any other way to dismiss it?), the window and buffer
> created by `log-edit-show-files', doesn't go anywhere, and I have to
> take care of it separately. Also fixable.

Indeed, that needs to be fixed.  It's easy to fix when we kill the
*vc-log* buffer, but it might be trickier to fix when you just bury-it :-(
Maybe log-edit-show-files shouldn't be in the default log-edit-hook.


        Stefan



  reply	other threads:[~2013-11-29 13:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VlqjS-0006O3-Fn@vcs.savannah.gnu.org>
2013-11-29  4:39 ` trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers Dmitry Gutov
2013-11-29 13:33   ` Stefan Monnier [this message]
2013-11-29 14:53     ` Dmitry Gutov
2013-11-29 17:04       ` Stefan Monnier
2013-11-29 22:37         ` Dmitry Gutov
2013-11-30  2:29           ` Stefan Monnier
2013-11-30 16:02             ` Dmitry Gutov
2013-12-01 21:10               ` Stefan Monnier
2013-12-02  2:40                 ` Dmitry Gutov
2013-12-02 13:53                   ` Stefan Monnier
2013-12-02 23:02                     ` Dmitry Gutov
2013-12-03  0:56                       ` Leo Liu
2013-12-03  3:06                       ` Stefan Monnier
2013-12-04  0:38                         ` Dmitry Gutov
2013-12-03  2:17                     ` Dmitry Gutov
2013-12-03  3:09                       ` Stefan Monnier
2013-12-04  0:43                         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzjone3vy.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.