From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Eldoc mode in eval-minibuffer Date: Mon, 20 Jan 2014 21:05:44 -0500 Message-ID: References: <83bnz6iqtr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390269980 6830 80.91.229.3 (21 Jan 2014 02:06:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jan 2014 02:06:20 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 21 03:06:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W5QjH-0007Lt-C5 for ged-emacs-devel@m.gmane.org; Tue, 21 Jan 2014 03:06:15 +0100 Original-Received: from localhost ([::1]:55282 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5QjG-0007PK-To for ged-emacs-devel@m.gmane.org; Mon, 20 Jan 2014 21:06:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Qj7-0007P7-Op for emacs-devel@gnu.org; Mon, 20 Jan 2014 21:06:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5Qj0-0007Sg-FB for emacs-devel@gnu.org; Mon, 20 Jan 2014 21:06:05 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Qis-0007Cz-QI; Mon, 20 Jan 2014 21:05:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoXIQ/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFsoXIQ/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45456672" Original-Received: from 108-161-114-16.dsl.teksavvy.com (HELO pastel.home) ([108.161.114.16]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Jan 2014 21:05:47 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9BB4C6026D; Mon, 20 Jan 2014 21:05:44 -0500 (EST) In-Reply-To: (Leo Liu's message of "Tue, 21 Jan 2014 09:32:01 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168809 Archived-At: > But previously it was enabled only after loading eldoc.el via add-hook > to eval-expression-minibuffer-setup-hook. > But then someone added a FIXME on that add-hook. Ah, that rings a bell, I was that someone. > While discarding the eldoc-post-insert-mode I thought I get rid of that > FIXME as well. Who would know someone would complain? ;) I think the way to get rid of that FIXME is to remove the `add-hook' but without replacing it with a mandatory call to eldoc-mode in read--expression. As for how to best enable eldoc-mode in the minibuffer, it's a good question. If the user enables (a hypothetical) global-eldoc-mode, then read--expression could check global-eldoc-mode to decide whether to enable eldoc-mode. Stefan