From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r116285: * lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Symbols don't start
Date: Thu, 06 Feb 2014 17:00:24 -0500 [thread overview]
Message-ID: <jwvzjm3sy3e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zjm4tl2b.fsf@yandex.ru> (Dmitry Gutov's message of "Thu, 06 Feb 2014 15:41:48 +0200")
>> + ;; Don't include all symbols
>> + ;; (bug#16646).
>> + (lambda (sym)
>> + (or (boundp sym)
>> + (fboundp sym)
>> + (symbol-plist sym)))
>> + 'strict))
> Shouldn't we also filter out functions (and maybe the symbols of the
> third kind), depending on whether there's a quote before BEG?
Yes, except that "a quote before BEG" is not sufficient.
We could/should also check if one of the parent open-parens is prefixed
with a quote or a backquote, and only allow boundp if not.
Stefan
next prev parent reply other threads:[~2014-02-06 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WBHeS-0000wr-6k@vcs.savannah.gnu.org>
2014-02-06 13:41 ` trunk r116285: * lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Symbols don't start Dmitry Gutov
2014-02-06 22:00 ` Stefan Monnier [this message]
2014-02-07 3:16 ` Michael Heerdegen
2014-02-07 13:22 ` Stefan Monnier
2014-02-11 3:43 ` Dmitry Gutov
2014-02-11 12:55 ` Michael Heerdegen
2014-02-11 14:47 ` Dmitry Gutov
2014-02-12 11:14 ` Michael Heerdegen
2014-02-13 5:13 ` Dmitry Gutov
2014-02-13 7:36 ` Michael Heerdegen
2014-02-13 13:33 ` Stefan Monnier
2014-02-14 3:48 ` Dmitry Gutov
2014-02-12 1:42 ` Stefan Monnier
2014-02-13 5:21 ` Dmitry Gutov
2014-02-13 12:56 ` Michael Heerdegen
2014-02-13 14:32 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzjm3sy3e.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.