From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Non-ASCII chars in quail rules Date: Wed, 03 Sep 2014 09:19:18 -0400 Message-ID: References: <20140829101804.4c904346@jabberwock.cb.piermont.com> <20140830184844.797d7340@jabberwock.cb.piermont.com> <20140831100035.6487ff7f@jabberwock.cb.piermont.com> <20140831172949.7ba54d1a@jabberwock.cb.piermont.com> <20140903074355.2a7cd6e2@jabberwock.cb.piermont.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1409750389 21240 80.91.229.3 (3 Sep 2014 13:19:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Sep 2014 13:19:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Perry E. Metzger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 03 15:19:42 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XPATO-0008Vi-91 for ged-emacs-devel@m.gmane.org; Wed, 03 Sep 2014 15:19:42 +0200 Original-Received: from localhost ([::1]:45341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPATN-0001H3-RS for ged-emacs-devel@m.gmane.org; Wed, 03 Sep 2014 09:19:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPATC-00015G-0v for emacs-devel@gnu.org; Wed, 03 Sep 2014 09:19:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPAT4-0002La-It for emacs-devel@gnu.org; Wed, 03 Sep 2014 09:19:29 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:37660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPAT4-0002KN-FD for emacs-devel@gnu.org; Wed, 03 Sep 2014 09:19:22 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s83DJIWu002473; Wed, 3 Sep 2014 09:19:19 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C04A860BEC; Wed, 3 Sep 2014 09:19:18 -0400 (EDT) In-Reply-To: <20140903074355.2a7cd6e2@jabberwock.cb.piermont.com> (Perry E. Metzger's message of "Wed, 3 Sep 2014 07:43:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5053=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5053> : inlines <1229> : streams <1280413> : uri <1809865> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173980 Archived-At: > One note: CHARACTERP does a bit more than is actually needed here, it > may be sufficient to say XINT (c) <= MAX_CHAR or to use the > CHAR_VALID_P macro. The only "more" it does, compared to XINT (c) <= MAX_CHAR is that it checks >=0 which is redundant because we already compared with ' '. > I am not sure what the intent here of the restriction was, but a more > general solution for the entire line of the test might be > CHAR_PRINTABLE_P depending on what that intent actually is. (I don't > entirely understand the intent, so I can't say.) The intent is to make sure that `c' is something we can insert in the buffer (since that's what quail does). We could also remove this check completely and allow using any event to trigger input-method-function, but that does break the current quail.el, so it's clearly more "backward incompatible". Stefan