From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Generalize start-process with keyword args Date: Wed, 18 Mar 2015 09:03:19 -0400 Message-ID: References: <87d24d3uwz.fsf-ueno@gnu.org> <83pp87y6iu.fsf@gnu.org> <83mw3bxz9f.fsf@gnu.org> <83k2yfx8zi.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426683840 25519 80.91.229.3 (18 Mar 2015 13:04:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Mar 2015 13:04:00 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Daiki Ueno Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 18 14:03:49 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYDdU-0006q8-Hf for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 14:03:48 +0100 Original-Received: from localhost ([::1]:33400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDdT-0002c7-N1 for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 09:03:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDdD-0002c1-Qq for emacs-devel@gnu.org; Wed, 18 Mar 2015 09:03:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYDd9-0003qo-G6 for emacs-devel@gnu.org; Wed, 18 Mar 2015 09:03:31 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDd4-0003pP-KD; Wed, 18 Mar 2015 09:03:22 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2ID3KnJ026811; Wed, 18 Mar 2015 09:03:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0384311C3; Wed, 18 Mar 2015 09:03:19 -0400 (EDT) In-Reply-To: (Daiki Ueno's message of "Wed, 18 Mar 2015 15:17:39 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5249=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5249> : inlines <2432> : streams <1407497> : uri <1883708> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183991 Archived-At: > I tend to agree with Stefan, as I find no documentation about the > implication of no-conversion for ":coding nil" except in the C source > code. Maybe we could add the exception back if it turns out to be too > confusing. We should probably also declare that uses of nil in other similar circumstances is deprecated (I actually don't know where are those places where nil means "binary"). > +If @var{coding} is @code{nil}, the coding system chosen for decoding > +output is @code{undecided}, meaning deduce the encoding from the > +actual data. Doesn't it also depend on coding-system-for-read and coding-system-for-write? > + tem = Fplist_get (contact, QCconnection_type); > + if (!NILP (tem)) > + { > + if (EQ (tem, Qpty)) > + XPROCESS (proc)->pty_flag = 1; > + else if (EQ (tem, Qpipe)) > + XPROCESS (proc)->pty_flag = 0; Please use `true' and `false' instead of 0 and 1. > + else > + report_file_error ("Unknown connection type", tem); > + } > + else > + XPROCESS (proc)->pty_flag = !NILP (Vprocess_connection_type); Any reason why you nested the "if/elseif/else" inside the outer "if" instead of having a 4-way "if/elseif/elseif/else"? [ Either way is fine by me, I'm just being curious here. ] Stefan