From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20608: 25.0.50; vc-git-log-view-mode inserts "Show 2X entries" at bob when interrupted Date: Sun, 24 May 2015 22:57:22 -0400 Message-ID: References: <86d21weqsc.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1432523262 1130 80.91.229.3 (25 May 2015 03:07:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 May 2015 03:07:42 +0000 (UTC) Cc: 20608@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 25 05:07:32 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ywijj-000662-Qw for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 May 2015 05:07:31 +0200 Original-Received: from localhost ([::1]:41717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywiji-0006dk-W1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 May 2015 23:07:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywiad-0006DP-Fz for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 22:58:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwiaZ-0001G1-0E for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 22:58:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwiaY-0001Fw-U5 for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 22:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YwiaY-0007ti-Bn for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 22:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2015 02:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20608 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20608-submit@debbugs.gnu.org id=B20608.143252265930329 (code B ref 20608); Mon, 25 May 2015 02:58:02 +0000 Original-Received: (at 20608) by debbugs.gnu.org; 25 May 2015 02:57:39 +0000 Original-Received: from localhost ([127.0.0.1]:55114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ywia6-0007t3-PE for submit@debbugs.gnu.org; Sun, 24 May 2015 22:57:39 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:57438) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ywia0-0007sl-5B for 20608@debbugs.gnu.org; Sun, 24 May 2015 22:57:33 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CYDQA731xV/9N+3mhcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtAQSLRKlAI4I7gVkigngBAQE X-IPAS-Result: A0CYDQA731xV/9N+3mhcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtAQSLRKlAI4I7gVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="122061216" Original-Received: from 104-222-126-211.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.222.126.211]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 May 2015 22:57:22 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 53684AE058; Sun, 24 May 2015 22:57:22 -0400 (EDT) In-Reply-To: <86d21weqsc.fsf@yandex.ru> (Dmitry Gutov's message of "Tue, 19 May 2015 14:43:31 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103149 Archived-At: > See the window shrink and "Show 2X entries Show unlimited entries" > appear at the top (it will also get added at the bottom when the process > finishes). > It seems like a general problem, to be fixed either in vc-do-command (by > unsetting the process sentinel before deleting the process), or in > vc--process-sentinel. Here's the patch for the second option: Could it be that the problem is that in vc-do-command we first do (unless (or (eq buffer t) (and (stringp buffer) (string= (buffer-name) buffer)) (eq buffer (current-buffer))) (vc-setup-buffer buffer)) and only afterwards do we do (let ((oldproc (get-buffer-process (current-buffer)))) ;; If we wanted to wait for oldproc to finish before doing ;; something, we'd have used vc-eval-after. ;; Use `delete-process' rather than `kill-process' because we don't ;; want any of its output to appear from now on. (when oldproc (delete-process oldproc))) ? -- Stefan