Re: Patches on ffap (mainly for latex buffers)

[Stefan Monnier <monnier@iro.umontreal.ca>]

> * lisp/ffap.el (ffap-string-at-point-mode-alist): Remove useless and
> misleading backslashes from default value.
[...]
> -    (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
> +    (file "--:\\\\${}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
                 ^^
This one as well, AFAIK.

> Subject: [PATCH 3/4] * lisp/ffap.el (ffap-latex-mode): Use kpsewhich if
>  available

Looks OK to me.

> +               (prefixes '(""
> +                           "beamertheme"
> +                           "beamercolortheme"
> +                           "beamerfonttheme"
> +                           "beamerinnertheme"
> +                           "beameroutertheme"))

These prefixes look rather ad-hoc.  Do we really need them?  Why?

> +               ;; is found before point on the current line. It should cover most
                                                              ^^^
Please put 2 spaces between sentences.

Also some of your lines are more than 80 columns wide.  Please try and
avoid that.

> The fourth (and last) patch fixes a problem introduced in commit
> ba6c32b6decaa2a72a3d5f854efd513e8e82c118, where braces were allowed in
> filenames. This is not good for TeX and friends, where braces are
> delimiters, as in \input{foo}.

Looks fine to me, thanks,


        Stefan