From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Overlay-related TODO
Date: Wed, 27 Apr 2016 08:56:15 -0400 [thread overview]
Message-ID: <jwvzisf9pyn.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CAAs=0-2K9f38KCcMJ1g++kFZmcDAufYkPWqc_73fZBnS3hJq3A@mail.gmail.com
> I believe that Stefan had something else in mind. As much as I understood
> he wanted to reuse the text property interval tree. I might have
> misunderstood something, but this would basically turn overlays into
> special text properties of sorts, and current overlay-related interface
> would be a bit harder to implement. Also, interval-handling code is all
> over textprop.c/interval.[ch]/buffer.c, and adding overlays on top of that
> does not sound all that reasonable to me.
> Again, I might have just misunderstood something.
> What do people here think about both approaches..?
Both approaches have advantages and disadvantages. Obviously, I think
re-using the intervals tree will have more advantages and fewer
disadvantages, but I can't see any obvious reason why we'd reject
a patch which uses your approach.
BTW, regarding the issue of testing, the way I'd try to do it is by
keeping adding the new implementation without removing the old one, and
adding assertions that check the new code returns the same answers as
the old one.
Stefan
next prev parent reply other threads:[~2016-04-27 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 21:59 Overlay-related TODO Vladimir Kazanov
2016-04-26 23:46 ` John Wiegley
2016-04-27 6:38 ` Eli Zaretskii
2016-04-27 11:40 ` Vladimir Kazanov
2016-04-27 12:56 ` Stefan Monnier [this message]
2016-04-27 19:03 ` John Wiegley
2016-04-28 20:09 ` Vladimir Kazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzisf9pyn.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.