From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ampc back on elpa? Date: Wed, 15 Jun 2016 09:35:43 -0400 Message-ID: References: <573736bd.442cc20a.8d117.ffff9cd7@mx.google.com> <5745411e.aaf0c20a.8e140.4623@mx.google.com> <575abfdd.697ac20a.d9403.5ca0@mx.google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465997725 19582 80.91.229.3 (15 Jun 2016 13:35:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 13:35:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 15 15:35:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDAyV-0002uv-3t for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 15:35:19 +0200 Original-Received: from localhost ([::1]:42193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDAyP-0006mI-GK for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 09:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDAxk-0006h9-8L for emacs-devel@gnu.org; Wed, 15 Jun 2016 09:34:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDAxd-0006wr-BR for emacs-devel@gnu.org; Wed, 15 Jun 2016 09:34:31 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:37716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDAxd-0006vc-57 for emacs-devel@gnu.org; Wed, 15 Jun 2016 09:34:25 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bDAxb-0002Ec-P3 for emacs-devel@gnu.org; Wed, 15 Jun 2016 15:34:23 +0200 Original-Received: from modemcable222.169-23-96.mc.videotron.ca ([96.23.169.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jun 2016 15:34:23 +0200 Original-Received: from monnier by modemcable222.169-23-96.mc.videotron.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jun 2016 15:34:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 84 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: modemcable222.169-23-96.mc.videotron.ca User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:Iu1phntt8yHbSGhckK1OfTYmUNc= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204383 Archived-At: > Only spaces here. One extra space before ,(kbd "F") > Fixed in new patch below. Is that the problem you are talking about? No the problem I was talking about was in my head. I just fixed it (lots more still to go, tho; it's can of hopeless in there, sorry). > I'm not documenting the code :-D I was just trying to understand it. I know. That's often the best way to document code. > I can't document this macro because I don't really know what it does. Oh well. > I put `delimiter` in all caps but I can't do more. Should I remove it? No, no, please don't remove it. > Done. I removed code in ampc-update and added a new function > ampc-start-search binded to the 's' key in search view. No need to > check minibuffer, using read-string and your nice `(setq > ampc-search-keywords (unless (string= "" search) search)))` line. Looks good. I was about to install the change into elpa.git but I can't find your name in the list of people who assigned copyright. Have you signed the copyright paperwork? If not, please fill the form below and send it as instructed to the FSF so they can send you the relevant paperwork to sign. In the mean time, here's a comment about: +(defun ampc-start-search () + "Ask mpd to search for songs matching keywords" + (interactive) + (cl-assert (ampc-in-ampc-p)) + (let ((search (read-string "Keywords: "))) This should look more like (defun ampc-start-search (search) "Ask mpd to search for songs matching keywords." (interactive "sKeywords: ") (cl-assert (ampc-in-ampc-p)) -- Stefan Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?]