all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo Liu <sdl.web@gmail.com>
Cc: 24585@debbugs.gnu.org
Subject: bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer
Date: Mon, 03 Oct 2016 09:24:50 -0400	[thread overview]
Message-ID: <jwvziml36tr.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m17f9qgmq9.fsf@gmail.com> (Leo Liu's message of "Mon, 03 Oct 2016 11:01:02 +0800")

>> IIUC this patch just changes the ordering for same-time timers.
>> Relying on either ordering is itself a hack.  We need a better solution.
> If you eval (progn (run-with-timer 0 ...)  ; timer 1
>                    (run-with-timer 0 ...)) ; timer 2
> you expect timer 1 to be triggered first, no?

Not really.  I think any code which relies on such a property will
sooner suffer.

>> What are those two timers whose relative execution order matters?
>> Why do they care in which order they're run?
> The first timer is compilation-auto-jump which is installed (by compile)
> at the start of compilation.
> The second timer is a cleanup timer which is installed (by ggtags) when
> compilation finishes and there is 0 or 1 match.
> The second timer kills the buffer (among other things) that the first
> timer depends on.

So we can fix the bug by making the timer's code check if the buffer is
still live?


        Stefan





  reply	other threads:[~2016-10-03 13:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02  4:56 bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer Leo Liu
2016-10-02 20:35 ` Stefan Monnier
2016-10-03  3:01   ` Leo Liu
2016-10-03 13:24     ` Stefan Monnier [this message]
2016-10-03 15:22       ` Leo Liu
2016-10-03 18:45         ` Stefan Monnier
2016-10-04 13:08           ` Leo Liu
2016-10-04 16:18             ` Stefan Monnier
2016-10-05  7:39               ` Leo Liu
2016-10-05 10:25                 ` Eli Zaretskii
2016-10-06 16:12                   ` Leo Liu
2016-10-06 18:10                     ` Stefan Monnier
2016-10-06 18:31                       ` Leo Liu
2016-10-06 18:37                         ` Eli Zaretskii
2016-10-07  1:21                           ` Leo Liu
2016-10-07  2:27                             ` Leo Liu
2016-10-07  8:02                               ` Eli Zaretskii
2016-10-07 12:46                               ` Stefan Monnier
2016-10-07 17:07                                 ` Leo Liu
2016-10-07 18:10                                   ` Stefan Monnier
2016-10-08 18:10                                     ` Leo Liu
2020-09-04 12:47                                       ` Lars Ingebrigtsen
2020-09-04 14:29                                         ` Stefan Monnier
2020-09-04 15:02                                           ` Lars Ingebrigtsen
2020-09-04 15:45                                             ` Stefan Monnier
2020-09-05 12:32                                               ` Lars Ingebrigtsen
2020-10-07  3:30                                                 ` Lars Ingebrigtsen
2016-10-07  7:59                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvziml36tr.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=24585@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.