From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch Date: Sat, 08 Oct 2016 11:43:11 -0400 Message-ID: References: <20161008093643.10907.90387@vcs.savannah.gnu.org> <20161008093643.BC95522015F@vcs.savannah.gnu.org> <83h98mhpci.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1475941574 18004 195.159.176.226 (8 Oct 2016 15:46:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Oct 2016 15:46:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 08 17:46:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bston-000170-TL for ged-emacs-devel@m.gmane.org; Sat, 08 Oct 2016 17:45:46 +0200 Original-Received: from localhost ([::1]:41540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstom-0007V9-IW for ged-emacs-devel@m.gmane.org; Sat, 08 Oct 2016 11:45:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstof-0007Uo-RC for emacs-devel@gnu.org; Sat, 08 Oct 2016 11:45:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bstoZ-0008GY-Mz for emacs-devel@gnu.org; Sat, 08 Oct 2016 11:45:36 -0400 Original-Received: from [195.159.176.226] (port=49451 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstoZ-0008E1-FN for emacs-devel@gnu.org; Sat, 08 Oct 2016 11:45:31 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bsto8-0004ZF-Bw for emacs-devel@gnu.org; Sat, 08 Oct 2016 17:45:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:RQ9uY0D7US1Zk7eiKMKG8PdrkFY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208104 Archived-At: >> > * lisp/isearch.el (isearch-update): Compute the window's body >> > width in a way that is correct when there are no fringes. >> > (Bug#24584) >> [...] >> > - (>= (car visible-p) (window-body-width nil t))) >> > + (>= (car visible-p) >> > + (* (window-max-chars-per-line) (frame-char-width)))) >> >> Hmm... shouldn't window-body-width return the right answer even when >> there are no fringes? > We were too afraid to make that change at the time, because some > callers don't (or might not) want that. Ah, so this is only for the emacs-25 branch, and on master we'll have "the right fix" instead? Makes sense, sorry 'bout the noise, Stefan