From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Warning compiling obarray.el on master Date: Sat, 18 Mar 2017 08:49:05 -0400 Message-ID: References: <83inn8z3ax.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489841415 26797 195.159.176.226 (18 Mar 2017 12:50:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 12:50:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 18 13:50:08 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpDny-0005Q6-1t for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 13:49:58 +0100 Original-Received: from localhost ([::1]:53218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpDo4-0001Nf-55 for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 08:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpDnR-0001NY-4U for emacs-devel@gnu.org; Sat, 18 Mar 2017 08:49:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpDnO-0003w0-2z for emacs-devel@gnu.org; Sat, 18 Mar 2017 08:49:25 -0400 Original-Received: from [195.159.176.226] (port=47791 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpDnN-0003vm-Re for emacs-devel@gnu.org; Sat, 18 Mar 2017 08:49:22 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cpDnA-0000Ux-A5 for emacs-devel@gnu.org; Sat, 18 Mar 2017 13:49:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:Tg45FpDOORCXZ1dNwkuit4mAlJU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213112 Archived-At: > ELC ../lisp/obarray.elc > In toplevel form: > obarray.el:40:1:Warning: Lexical argument shadows the dynamic variable obarray It's "harmless" and it's the result of having a global variable with a short name like `obarray` which hence unavoidably collides with local uses. I see the rest of obarray.el uses the name `ob` for local variables instead, so I guess using that in `obarray-copy` is the best fix in the short term. In the longer term, maybe we should rename `obarray` to something more descriptive and less likely to collide with a local var. Maybe `default-obarray` or `global-obarray` or `global-identifier-obarray`? Stefan