From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Thu, 13 Apr 2017 14:37:03 -0400 Message-ID: References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1492108819 1502 195.159.176.226 (13 Apr 2017 18:40:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Apr 2017 18:40:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 13 20:40:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyjfD-0000IM-3b for ged-emacs-devel@m.gmane.org; Thu, 13 Apr 2017 20:40:15 +0200 Original-Received: from localhost ([::1]:50430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyjfJ-00035r-4Z for ged-emacs-devel@m.gmane.org; Thu, 13 Apr 2017 14:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyjfD-00035i-6y for emacs-devel@gnu.org; Thu, 13 Apr 2017 14:40:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyjf9-0001C1-7y for emacs-devel@gnu.org; Thu, 13 Apr 2017 14:40:15 -0400 Original-Received: from [195.159.176.226] (port=60280 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyjf9-0001AX-1S for emacs-devel@gnu.org; Thu, 13 Apr 2017 14:40:11 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cyjf1-0008WQ-KP for emacs-devel@gnu.org; Thu, 13 Apr 2017 20:40:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:2MfKoZEfENRASlHOK/1BMui/XIw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213945 Archived-At: >> - Why would we want to run abort-recursive-edit when we're in the minibuffer? > I clearly remember that the intention was to discard the minibuffer when > the user clicks on the big cross, i.e. the "Close" button in the toolbar, > because its mnemonics suggests to close the currently active buffer - > if it's the minibuffer, then close the minibuffer. I see, thanks, that makes sense, indeed. >> - Why did we decide to use menu-bar-non-minibuffer-window-p rather than >> checking something like (window-minibuffer-p (frame-selected-window))? > ‘menu-bar-non-minibuffer-window-p’ already does this, and additionally > takes into account ‘menu-updating-frame’ and checks for ‘frame-live-p’. But that's exactly the question: why pay attention to menu-updating-frame and frame-live-p? Stefan