From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: syntax based indentation for SQL files (ELPA package proposal) Date: Sun, 06 Aug 2017 13:54:22 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1502042132 11890 195.159.176.226 (6 Aug 2017 17:55:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2017 17:55:32 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Michael Mauger , Alex Harsanyi , pierre.techoueyres@free.fr To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 06 19:55:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dePlo-0002Wz-5U for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2017 19:55:20 +0200 Original-Received: from localhost ([::1]:33925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dePlu-0000Ro-87 for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2017 13:55:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dePlD-0000RM-GL for emacs-devel@gnu.org; Sun, 06 Aug 2017 13:54:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dePlA-0003tl-FH for emacs-devel@gnu.org; Sun, 06 Aug 2017 13:54:43 -0400 Original-Received: from [195.159.176.226] (port=60321 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dePlA-0003tX-7s for emacs-devel@gnu.org; Sun, 06 Aug 2017 13:54:40 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dePl0-00006Z-Bh for emacs-devel@gnu.org; Sun, 06 Aug 2017 19:54:30 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:fkFRKn+T+71VFZ3r5+gukzLdVco= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217342 Archived-At: > I'm not sure what are the next steps for this? I think the main question is whether it can/should be included in sql.el. Maybe the best strategy is the following: - add sqlindent.el more-or-less as-is into Emacs's `master` branch as lisp/progmodes/sqlindent.el - change sql.el to use that indentation package by default. Michael, what do you say? Do you want to include sqlindent.el directly into sql.el? > I already have signed copyright assignment for GNU Emacs contributions > in the past. The package has another contributor, Pierre Téchoueyres, > I'm not sure if he has signed the copyright assignment papers or not > (I just sent him an email asking this). Yes, he has already signed paperwork for Emacs. > I think this should be a separate package, at least initially. Based > on feedback from Michael who maintains sql.el, there might be people > who prefer the way sql-mode works now, as it has been like this for a > long time. I believe the default behavior should be to enable automatic indentation. We can provide some way for the user to disable it, of course (actually, I think it would make sense to offer a generic minor mode which provides "dumb" indentation in any major mode). Stefan