From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Date: Sun, 15 Oct 2017 21:30:52 -0400 Message-ID: References: <20171008231448.29638.520@vcs0.savannah.gnu.org> <20171008231451.3FBBC20326@vcs0.savannah.gnu.org> <87a80xadug.fsf@runbox.com> <87zi8smgjs.fsf@runbox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508117521 20125 195.159.176.226 (16 Oct 2017 01:32:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 01:32:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 16 03:31:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3uFy-0003mM-BP for ged-emacs-devel@m.gmane.org; Mon, 16 Oct 2017 03:31:50 +0200 Original-Received: from localhost ([::1]:58904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3uG5-0002jl-EQ for ged-emacs-devel@m.gmane.org; Sun, 15 Oct 2017 21:31:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3uFS-0002jg-T6 for emacs-devel@gnu.org; Sun, 15 Oct 2017 21:31:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3uFN-0002mJ-Sf for emacs-devel@gnu.org; Sun, 15 Oct 2017 21:31:17 -0400 Original-Received: from [195.159.176.226] (port=40175 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3uFN-0002lF-Lu for emacs-devel@gnu.org; Sun, 15 Oct 2017 21:31:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e3uF4-0005jA-2O for emacs-devel@gnu.org; Mon, 16 Oct 2017 03:30:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:7T2RNyMyMXaYUlpNLdzCa+qU7GQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219559 Archived-At: > Here's a tested patch, with documentation. In it I've changed both > hooks to variables, and chosen to let-bind them in Testcover. Looks great. > I don't know why you used add-function in your first patch, but if you can > educate me, I'll change what needs changing. I think it was just to better match the previous code which used add-hook. Your solution using just let seems cleaner, Stefan