From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes
Date: Sun, 15 Oct 2017 21:30:52 -0400 [thread overview]
Message-ID: <jwvzi8rnam0.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87zi8smgjs.fsf@runbox.com
> Here's a tested patch, with documentation. In it I've changed both
> hooks to variables, and chosen to let-bind them in Testcover.
Looks great.
> I don't know why you used add-function in your first patch, but if you can
> educate me, I'll change what needs changing.
I think it was just to better match the previous code which used add-hook.
Your solution using just let seems cleaner,
Stefan
next prev parent reply other threads:[~2017-10-16 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171008231448.29638.520@vcs0.savannah.gnu.org>
[not found] ` <20171008231451.3FBBC20326@vcs0.savannah.gnu.org>
2017-10-09 4:13 ` [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Stefan Monnier
2017-10-11 15:44 ` Gemini Lasswell
2017-10-11 16:11 ` Stefan Monnier
2017-10-15 18:06 ` Gemini Lasswell
2017-10-16 1:30 ` Stefan Monnier [this message]
2017-10-11 20:02 ` Alan Mackenzie
2017-10-11 20:32 ` Stefan Monnier
2017-10-11 20:36 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzi8rnam0.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.