From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Date: Tue, 02 Jan 2018 22:50:52 -0500 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514951419 25162 195.159.176.226 (3 Jan 2018 03:50:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 Jan 2018 03:50:19 +0000 (UTC) To: 29956@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 03 04:50:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa49-0005sb-VJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jan 2018 04:50:10 +0100 Original-Received: from localhost ([::1]:37841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWa69-0006ml-2D for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 22:52:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWa62-0006mE-3s for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:52:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa5y-0002R7-Th for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:52:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWa5y-0002Qy-Qo for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWa5y-0007UL-HR for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2018 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151495146928718 (code B ref -1); Wed, 03 Jan 2018 03:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jan 2018 03:51:09 +0000 Original-Received: from localhost ([127.0.0.1]:33698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa57-0007T8-Dz for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa54-0007Sa-7S for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4y-0001Xx-3B for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWa4x-0001Xo-Vx for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWa4w-0006Xy-Lz for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4t-0001Tb-Ed for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:58 -0500 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:15425) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWa4t-0001SV-8p for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjjiYBgjMBglyWLwoThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAyFUYkYhTAFkiCBFJAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ X-IPAS-Result: A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjjiYBgjMBglyWLwoThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAyFUYkYhTAFkiCBFJAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ X-IronPort-AV: E=Sophos;i="5.45,500,1508817600"; d="scan'208";a="17183745" Original-Received: from 107-179-155-99.cpe.teksavvy.com (HELO ceviche.home) ([107.179.155.99]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 22:50:53 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id D72A7662E5; Tue, 2 Jan 2018 22:50:52 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141736 Archived-At: Package: Emacs Version: 26.0.90 % src/emacs -Q lisp/emacs-lisp/pcase.el ...Select the first (def-edebug-spec ...) C-x v h In the *VC-history* buffer, hit `d' This gives me `Wrong type argument: sequencep, 47' [ Which file you use, and which region of the file you select doesn't really matter. ] The patch below fixes it for me. Is it OK to install it into emacs-26, or should I keep it on `master`? FWIW, it's not a new bug in Emacs-26 and it's not terribly urgent to fix it, e.g. because you can use `D' which does work (tho it doesn't do quite the same), so I'm fine with either choice. Stefan diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 7c502f88df..0a87e70017 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2426,9 +2426,11 @@ vc-region-history (setq-local vc-log-view-type 'long)) (vc-call region-history file buf lfrom lto) (with-current-buffer buf + (setq default-directory (file-name-directory file)) (vc-call-backend backend 'region-history-mode) (set (make-local-variable 'log-view-vc-backend) backend) - (set (make-local-variable 'log-view-vc-fileset) file) + (set (make-local-variable 'log-view-vc-fileset) + (list (file-relative-name file))) (set (make-local-variable 'revert-buffer-function) (lambda (_ignore-auto _noconfirm) (with-current-buffer buf