* Re: [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files
[not found] ` <20190501152059.0E9D9209A5@vcs0.savannah.gnu.org>
@ 2019-05-01 15:50 ` Stefan Monnier
2019-05-01 16:27 ` Eric Abrahamsen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-05-01 15:50 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: emacs-devel
> * lisp/gnus/gnus-util.el (gnus-write-active-file): This doesn't do
> what I thought it would do.
[...]
> - (insert (format ";; -*- encoding: %s; -*-\n\n" coding-system-for-write))
Not sure what you expect it to do, but the above cookie indeed likely
doesn't do anything at all. If you change `encoding` to `coding` then
it should have the effect of telling Emacs which encoding to use when
reading the file.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files
2019-05-01 15:50 ` [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files Stefan Monnier
@ 2019-05-01 16:27 ` Eric Abrahamsen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Abrahamsen @ 2019-05-01 16:27 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/gnus/gnus-util.el (gnus-write-active-file): This doesn't do
>> what I thought it would do.
> [...]
>> - (insert (format ";; -*- encoding: %s; -*-\n\n" coding-system-for-write))
>
> Not sure what you expect it to do, but the above cookie indeed likely
> doesn't do anything at all. If you change `encoding` to `coding` then
> it should have the effect of telling Emacs which encoding to use when
> reading the file.
Well that's embarrassing! I was wrong on two levels. It was later
pointed out to me (this is in the later discussion on #35383) that the
cookie wouldn't even influence how Emacs read the file in this case, so
there wasn't much point. Right now the code assumes that it will be able
to read files written as 'raw-text using 'utf-8-emacs.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-01 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190501152057.8555.99227@vcs0.savannah.gnu.org>
[not found] ` <20190501152059.0E9D9209A5@vcs0.savannah.gnu.org>
2019-05-01 15:50 ` [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files Stefan Monnier
2019-05-01 16:27 ` Eric Abrahamsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.