From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Mon, 27 May 2019 23:08:36 -0400 Message-ID: References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253155"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 28 05:08:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVSTt-0013lE-TK for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 05:08:54 +0200 Original-Received: from localhost ([127.0.0.1]:56291 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVSTs-00037O-TR for ged-emacs-devel@m.gmane.org; Mon, 27 May 2019 23:08:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVSTm-00037I-Mf for emacs-devel@gnu.org; Mon, 27 May 2019 23:08:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVSTl-0007dC-QA for emacs-devel@gnu.org; Mon, 27 May 2019 23:08:46 -0400 Original-Received: from [195.159.176.226] (port=54982 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVSTl-0007cd-KI for emacs-devel@gnu.org; Mon, 27 May 2019 23:08:45 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hVSTi-0013b1-Ju for emacs-devel@gnu.org; Tue, 28 May 2019 05:08:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:14mdijZJFDi7EafQ30M0+zhyisI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237070 Archived-At: > Since this is the underlying code that displays the 'buffer code' > section of 'C-u C-x =', I donʼt think barfing on multibyte is the > right thing to do. Nor is passing it on as is. grep gives me: % grep --color -nH --null -e encoded-string-description **/*.el descr-text.el\0350: (encoded-string-description encoded coding))))) descr-text.el\0645: (encoded-string-description descr-text.el\0655: (list (encoded-string-description encoded coding) international/mule-cmds.el\02900:(defun encoded-string-description (str coding-system) simple.el\01481: (encoded-string-description encoded coding))) and according to my quick investigation, all callers pass a string that's coming straight from encode-coding-string or encode-coding-char, so the argument should *always* be unibyte, AFAICT. Hence according to my reading of the code, this call to string-as-unibyte will always just return its argument unchanged. Stefan