From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch Date: Mon, 22 Jul 2019 09:40:50 -0400 Message-ID: References: <20190721193221.1964.53182@vcs0.savannah.gnu.org> <20190721193222.8C19E20BE2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33328"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 22 15:41:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpYYq-0008YV-Rg for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 15:41:04 +0200 Original-Received: from localhost ([::1]:33706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYp-0006np-Rm for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 09:41:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54443) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYh-0006JG-Fa for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:40:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYYg-0004n9-Ki for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:40:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39376) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYYg-0004m0-Fu for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:40:54 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3F197445281; Mon, 22 Jul 2019 09:40:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 378A144527E; Mon, 22 Jul 2019 09:40:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1563802852; bh=wUn8/sgwhb39IUEtbxHQ+VroupWk9gCmz94WIVizfBU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NWjEWmbgq3XE4xKSTvTMsyDClDCWCe5RzxViADMXIRFgVfNo2OTMupCSwXIvlFuxn lQzf95c1sC+/M4zliP6+svSskT6Tj106oeamjil3o2nB7Gex0duDJXKAs05aWW86Oa YFfIEwlJfAfG8RXopCXYDz4Btc1rK7GSMeJ6FxXoNZT2EueZF/7NN+uHe0hOZ2YirD Lc6F6w/6gNyC6zQMm1rMSAGk3xfpRas0MqPr+ypmNheR30BQ77ycKFbdh6h1AsBeaP wHkrwnqkQEOafTBXBDcXJhPBDiY5/5Xp2DBD3IgdetENXv8w8IohQqrWaIb3dWPiN1 H3IrfXwnUUDXA== Original-Received: from pastel (unknown [216.154.19.233]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EA8E3121499; Mon, 22 Jul 2019 09:40:51 -0400 (EDT) In-Reply-To: (Pip Cet's message of "Mon, 22 Jul 2019 04:12:05 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238787 Archived-At: > Shouldn't we count the allocations that happened while GC was > inhibited and subtract them from consing_until_gc afterwards? I don't see why: they are counted already in consing_since_gc, no? Stefan