From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 270ca8c: Fix internal-lisp-face-attributes to match face. Date: Sun, 20 Oct 2019 14:28:22 -0400 Message-ID: References: <20191020144609.32634.23000@vcs0.savannah.gnu.org> <20191020144611.3484F20BBC@vcs0.savannah.gnu.org> <87eez7toah.fsf@gmx.net> <83wocz4cxb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92512"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: spacibba@aol.com, Stephen Berman , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 20 20:29:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMFxB-000Nuo-Sd for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 20:29:22 +0200 Original-Received: from localhost ([::1]:43298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMFxA-0000k2-86 for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 14:29:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42417) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMFwP-0000jn-4C for emacs-devel@gnu.org; Sun, 20 Oct 2019 14:28:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMFwN-0007xS-LU for emacs-devel@gnu.org; Sun, 20 Oct 2019 14:28:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60234) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMFwJ-0007wc-MZ; Sun, 20 Oct 2019 14:28:27 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 15EEF4491CD; Sun, 20 Oct 2019 14:28:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B6791447D78; Sun, 20 Oct 2019 14:28:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571596104; bh=P8zE+fyqOhopd6B4r0pE0gRwyzUI770hY5ez0RUTWjc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Fcw34jutuF5bNkGsMTnUzYjdqmdAME8mfKVSGL/fbnPxczACsumw2BpKduBiwIwZs 6Od2DrQDBZXRhXCj/hu4DcLoIAf0BcI066mRNW8lX2aDN+qWv9YDuqzBOnfGEqu/ys Zpu40ZuQOOOMSckjF/j5jiC8yS+i20rWwL8ii4FpaaENW1n59wSbsrUSoc4F4295ki zoBfBJl3txIc4MySx55G1zrB3cX1B5HcuPv6sS81Pa98QQyZnW3LiU8zBxEVkpn6yn 2FxWgRirMKeNxltLx4KgdMEf2zCLwgi7Kqx3bsloL52Qk9ribjoXlQgvziQUtEnVSX P9Q3RuVerMXTA== Original-Received: from pastel (unknown [216.154.15.203]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 641A3120396; Sun, 20 Oct 2019 14:28:24 -0400 (EDT) In-Reply-To: <83wocz4cxb.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Oct 2019 19:08:48 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241258 Archived-At: >> > * lisp/face-remap.el (internal-lisp-face-attributes): Updated the >> ^^^^^^^ >> The conventional practice is to use the imperative form of verbs in >> commit messages (so here "Update"). Indeed. The comment should describe what the change does rather than what it did. >> (I couldn't find documentation of this practice It comes from the GNU Coding Standards (https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs), where it's not described in the text but can be seen in the example. > Because there's nothing wrong with "Updated", IMO. It's less consistent with the rest of our changelogs, and it wastes a precious byte (and sometimes an even more precious column). > You will find, for example, "Function removed" and the likes in > the logs. That's a passive form, and I prefer the active form. This said, it's clearly much less important than the actual content of the description. Stefan