From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049. Date: Thu, 14 Nov 2019 09:55:58 -0500 Message-ID: References: <20191109144026.20810.76129@vcs0.savannah.gnu.org> <20191109144027.DDC3720927@vcs0.savannah.gnu.org> <38328d99-23c8-7ba7-a23d-e70ac0aab67a@yandex.ru> <20191111203445.GA5135@ACM> <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> <20191113211936.GB4942@ACM> <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> <03042d05-2160-77c4-9abd-b0f13f638247@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103074"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alan Mackenzie , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 15:56:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVGY2-000Qbz-Od for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 15:56:39 +0100 Original-Received: from localhost ([::1]:58416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGY1-0006wa-Ke for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 09:56:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54714) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVGXW-0006wP-GN for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:56:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVGXU-00083s-Hr for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:56:05 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44173) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iVGXU-00083k-BD for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:56:04 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 48786449CD0; Thu, 14 Nov 2019 09:56:03 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0B18F449CCE; Thu, 14 Nov 2019 09:56:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1573743362; bh=tL4P5CSmabes8GtX+xaxQEkXon9zapOpGs9ioXnydWo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YsXsY8z72M4XAMo77E+NZIBrxYo005WNNg9lhx5zpeFgifdGrhpg+Br7qoXVv0k65 GC8N9kJyXWJO1Vd2jTUaR5bLlf6vuHuRqPsikWrSX7VAR2A1/KKzN6SGRm/KJZE5ju TIMpkJkNUlIdNvBw99VW7IUL201npBzP/O19tD1vDOwSNEV5iwe0P6/Yua2b/oxPVd 9BWoIpnjVMeBAv2qOUHXY4wfZJ5TGTtPELpvb03TLezNe2IKqnjROayaEbrsh1z2bt Ufo6NHXIOn+LsJHUsi1qcdO2gcM9XJxBBY4dl0qTETDIolUPtqgxZyap9znlfs4WQ9 TLQkm5RcF/rHg== Original-Received: from pastel (206-248-133-142.dsl.teksavvy.com [206.248.133.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BD688120484; Thu, 14 Nov 2019 09:56:01 -0500 (EST) In-Reply-To: <03042d05-2160-77c4-9abd-b0f13f638247@yandex.ru> (Dmitry Gutov's message of "Thu, 14 Nov 2019 16:37:50 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242181 Archived-At: > diff --git a/lisp/reposition.el b/lisp/reposition.el > index 22f9986efb..5d9c3180ad 100644 > --- a/lisp/reposition.el > +++ b/lisp/reposition.el > @@ -174,8 +174,8 @@ reposition-window > (defun repos-count-screen-lines (start end) > (save-excursion > (save-restriction > - (narrow-to-region start end) > - (goto-char (point-min)) > + (narrow-to-region (point-min) end) > + (goto-char start) > (vertical-motion (- (point-max) (point-min)))))) This looks like a good change in any case, tho it does beg the question: why does it narrow? Also, I think I'm beginning to understand: the issue is that vertical-motion uses the redisplay code, which in turn calls jit-lock when needed. So, your earlier patch which added a call to `font-lock-ensure` was "more or less right", except that it should have used `jit-lock-ensure` (currently called `jit-lock-fontify-now`) and could have a comment explaining that vertical-motion will trigger jit-lock anyway so it's better to do it once beforehand on the whole region, not only so it can be done outside of the narrowing but also so it can be done more efficiently than one jit-lock-chunk-size at a time. Stefan