From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49143: 28.0.50; find-file-literally doesn't ignore `mode:` Date: Sun, 20 Jun 2021 13:54:32 -0400 Message-ID: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6756"; mail-complaints-to="usenet@ciao.gmane.io" To: 49143@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 20 19:55:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lv1f3-0001V5-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Jun 2021 19:55:10 +0200 Original-Received: from localhost ([::1]:49844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lv1f2-0004F6-1p for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Jun 2021 13:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv1ev-0004Ex-Tv for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 13:55:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lv1ev-0003Fl-Ml for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 13:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lv1ev-0002b2-MR for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 13:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Jun 2021 17:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49143 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16242116929957 (code B ref -1); Sun, 20 Jun 2021 17:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jun 2021 17:54:52 +0000 Original-Received: from localhost ([127.0.0.1]:34879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lv1em-0002aX-JI for submit@debbugs.gnu.org; Sun, 20 Jun 2021 13:54:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lv1el-0002aL-8e for submit@debbugs.gnu.org; Sun, 20 Jun 2021 13:54:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv1ek-0004EZ-VE for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 13:54:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv1eh-00035J-VC for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 13:54:49 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7F9DE10028B for ; Sun, 20 Jun 2021 13:54:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 46E9D1000C9 for ; Sun, 20 Jun 2021 13:54:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624211684; bh=JEcENNkaHiq/oxaQF7aYdzQsm/XyDYdpLlQZgw/gZX4=; h=From:To:Subject:Date:From; b=ciZ0Levt06wtcbIJaV7e+APl1/O13jvsAmV1mPAqJ3zMP8orQiI3+C1HzS6gOj+RK 0oV9xyOCom4sfi2Ilnb0P7v8rJbwYkQus5qdem6pEEyXR4pvzxfA4Xe9X141IKYeaE xmv//b44s2V/bvejlk/DyfcC2TKBgXBU6LBnVwmfiml7A+Ll/93MDcUuuF1nUz9REK M2W8jIqL65iotB18a1WVONpIuWhszlh/bj7PqfBHb8qgZLy2hRMDiYIEb0blIF2zfP X6mgC3VHSVEtStHKg82dB0M/CLyMPLfJ6NG2zrxLXVzMJmurIet4mYyDQy1NqYHnpN 2fZEEdJ/zYsPA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2EE0C120177 for ; Sun, 20 Jun 2021 13:54:44 -0400 (EDT) Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208800 Archived-At: Package: Emacs Version: 28.0.50 Contrary to its documentation, it seems that `find-file-literally` doesn't ignore file-local `mode:` settings any more, as evidenced by the following backtrace: dismal-mode() hack-one-local-variable(mode dismal) hack-local-variables-apply() hack-local-variables(no-mode) run-mode-hooks() fundamental-mode() set-buffer-major-mode(#) set-auto-mode() normal-mode(t) after-find-file(nil t) find-file-noselect-1(# "~/tmp/normalization.dis" nil nil "~/tmp/normalization.dis" (1347023 65026)) find-file-noselect("~/tmp/normalization.dis") I suspect the culprit is commit 5bedbe6b1d5f4b801abf91b4d023d5c4e66418f0 Author: Lars Ingebrigtsen Date: Mon May 10 12:40:11 2021 +0200 Always heed the `lexical-binding' local variable * doc/lispref/variables.texi (File Local Variables): Document `permanently-enabled-local-variables'. * lisp/files.el (enable-local-variables): Mention the new variable. (set-auto-mode): Always call `hack-local-variables'. (hack-local-variables): Factor out the variable gathering into its own function, and respect the new variable (bug#47843). (hack-local-variables--find-variables): Factored out from `hack-local-variables'. (permanently-enabled-local-variables): New variable. -- Stefan