From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Obsolete variable in cc-defs.el
Date: Mon, 17 Oct 2022 17:54:12 -0400 [thread overview]
Message-ID: <jwvzgduazp6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <Y02IllfCjGfiAYzc@ACM> (Alan Mackenzie's message of "Mon, 17 Oct 2022 16:53:42 +0000")
> That is a mistake in declaring inhibit-point-motion-hooks obsolete. As
> long as the properties point_entered and point_left exist and work
> (regardless of whether they are declared obsolete),
> inhibit-point-motion-hooks is required. It's use shouldn't (yet)
> generate any warnings.
You don't need to let-bind it to t in Emacs≥25 because its default value
is already t. So for Emacs≥25 you should simply remove that let-binding.
> It's obsolesence message is also suboptimal.
Indeed: it is meant for the case where you set or let-bind that variable
to nil rather than when you set/bind it to t.
> That role will be fulfilled by the variable cursor-sensor-inhibit,
> which really ought to be in c-save-buffer-state (in cc-defs.el)
> alongside i-p-m-h.
You don't need it there and let-binding it there would have no effect at
all unless the body of `c-save-buffer-state` does things like run
a recursive-edit or pause for redisplay (that var is only consulted
"outside", e.g. from `post/pre-command-hook` or
`pre-redisplay-functions`).
Stefan
next prev parent reply other threads:[~2022-10-17 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 8:59 Obsolete variable in cc-defs.el Lars Ingebrigtsen
2022-10-17 16:53 ` Alan Mackenzie
2022-10-17 21:54 ` Stefan Monnier [this message]
2022-10-18 8:26 ` Alan Mackenzie
2022-10-17 21:59 ` Stefan Monnier
2022-10-18 9:30 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzgduazp6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.