From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] main 2ec80977e1: * elpa-packages (dired-preview): New package Date: Tue, 11 Jul 2023 09:33:14 -0400 Message-ID: References: <168884609732.27984.6450580686777461843@vcs2.savannah.gnu.org> <20230708195457.95F1AC11DD8@vcs2.savannah.gnu.org> <87zg43iprw.fsf@posteo.net> <87edlfbjsx.fsf@protesilaos.com> <87v8eqc2k9.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9249"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Protesilaos Stavrou , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 11 15:34:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJDVR-0002AZ-MO for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jul 2023 15:34:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJDUY-0004y4-SL; Tue, 11 Jul 2023 09:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJDUX-0004xv-Va for emacs-devel@gnu.org; Tue, 11 Jul 2023 09:33:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJDUV-0000yC-Ny for emacs-devel@gnu.org; Tue, 11 Jul 2023 09:33:21 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8ED751000C3; Tue, 11 Jul 2023 09:33:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 51925100084; Tue, 11 Jul 2023 09:33:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689082396; bh=FIfZyNxQbKwFl7xeoOpozKus8/nJ6w/ir/HSUtnarbc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=f0DuhN0aBxV/+NyhzlxdVnyB78993ES3WsESUpUZ4HR4haouWbfAsD8o5NZYUXt/R 4Wzx/WH+xrplpIhry/3OiEeHPZN03RixROYenOVOvO6porK1pwY1fbmVukHnRvCWHd bB9NDGqeOqcTdtaJWPPioPcbI0gHkHYuT76uaAJ2QA10OwK1sPQjbI+96869V2I0ww LqT5BU0v8WO40DXnqs1Xr2ZYaL0GW2vXmwcgLVVIrf+QzDKwViYulKG6DzpOkHGPCF GWU8gOWeikYiiokr9e+mlMMDn9TGVG5walxED6aEcluP1FaAs+j3T4e4e+JsOB6cuq wuhquBixpI1WQ== Original-Received: from pastel (69-165-150-192.dsl.teksavvy.com [69.165.150.192]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A66D12037A; Tue, 11 Jul 2023 09:33:16 -0400 (EDT) In-Reply-To: <87v8eqc2k9.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 11 Jul 2023 07:47:18 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307749 Archived-At: >> I saw 'rx' a couple of times. I find it harder to use than the strings. >> Though this is not a strong argument against it, I know. > > In this case, it would be > > --8<---------------cut here---------------start------------->8--- > (rx "." (or "mkv" "webm" "mp4" "mp3" "ogg" "m4a" > "gz" "zst" "tar" "xz" "rar" "zip" > "iso" "epub" "pdf")) > --8<---------------cut here---------------end--------------->8--- > > which seems fine to me? Fewer escape-sequences. > >>> "\\(mkv\\|webm\\|mp4\\|mp3\\|ogg\\|m4a" >>> "\\|gz\\|zst\\|tar\\|xz\\|rar\\|zip" >>> "\\|iso\\|epub\\|pdf\\)") >>> "Regular expression of file type extensions to not preview." >>> - :group 'dired-preview >>> :type 'string) BTW, you can most of the benefit here by using `regexp-opt` instead: (concat "\\." (regexp-opt "mkv" "webm" "mp4" "mp3" "ogg" "m4a" "gz" "zst" "tar" "xz" "rar" "zip" "iso" "epub" "pdf")) > So unless you can make use of =CE=B7-reduction, mapc incurs an overhead of > a funcall overhead for each element, but had an advantage in that > iteration happens in-core. For the specific case at hand, there's also the cost of allocating the closure and converting the free variable into a cons-cell (because it's modified) which slows down accesses to it. IOW (let ((size 0)) (mapc (lambda (buffer) (setq size (+ (buffer-size buffer) size))) (dired-preview--get-buffers)) size)) will look somewhat like: (let ((size (list 0))) (mapc (make-closure (lambda (buffer) (setcar V0 (+ (buffer-size buffer) (car V0)))) size) (dired-preview--get-buffers)) (car size)) See bytecode below. Stefan byte code: args: nil 0 constant 0 1 list1=20=20=20=20=20 2 constant mapc 3 constant make-closure 4 constant doc: ... args: (arg1) 0 constant V0 1 constant buffer-size 2 stack-ref 2 3 call 1 4 constant V0 5 car-safe=20=20 6 plus=20=20=20=20=20=20 7 setcar=20=20=20=20 8 return=20=20=20=20 5 stack-ref 3 6 call 2 7 constant dired-preview--get-buffers 8 call 0 9 call 2 10 discard=20=20=20 11 car-safe=20=20 12 return=20=20=20=20